threads / discuss / 32135

git-credential-gnome-keyring fails at multilib

Subject: git-credential-gnome-keyring fails at multilib

## tl;dr

One message between Nov 17, 2012 and Nov 17, 2012.

replies: 0people: 1as markdown or json

Peter Alfredsen· Nov 17, 2012, 14:05 UTC · lore
Downstream bug report: https://bugs.gentoo.org/443634

The git-credential-gnome-keyring Makefile doesn't allow overriding its variables, making for spectacular link failure if you use CFLAGS for aught but decoration.

gcc -g -O2 -Wall -I/usr/include/gnome-keyring-1 -I/usr/include/glib-2.0 -I/usr/lib32/glib-2.0/include -o git-credential-gnome-keyring.o -c git-credential-gnome-keyring.c gcc -o git-credential-gnome-keyring -Wl,--as-needed -Wl,--hash-style=gnu -m32 git-credential-gnome-keyring.o -lgnome-keyring -lglib-2.0 /usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld: i386:x86-64 architecture of input file `git-credential-gnome-keyring.o' is incompatible with i386 output /usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld: git-credential-gnome-keyring.o: file class ELFCLASS64 incompatible with ELFCLASS32 /usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld: final link failed: File in wrong format collect2: error: ld returned 1 exit status

Attached patch fixes it.
/Peter

diff -NrU5 git-1.8.0.orig/contrib/credential/gnome-keyring/Makefile git-1.8.0/contrib/credential/gnome-keyring/Makefile --- git-1.8.0.orig/contrib/credential/gnome-keyring/Makefile 2012-11-17 14:45:06.536641381 +0100 +++ git-1.8.0/contrib/credential/gnome-keyring/Makefile 2012-11-17 14:45:40.883442939 +0100

@@ -1,11 +1,11 @@
 MAIN:=git-credential-gnome-keyring
 all:: $(MAIN)
 
-CC = gcc
-RM = rm -f
-CFLAGS = -g -O2 -Wall
+CC ?= gcc
+RM ?= rm -f
+CFLAGS ?= -g -O2 -Wall
 
 -include ../../../config.mak.autogen
 -include ../../../config.mak
 
 INCS:=$(shell pkg-config --cflags gnome-keyring-1)

← back to recent threads