{"thread":{"id":"32135","subject":"git-credential-gnome-keyring fails at multilib","startedAt":"2012-11-17T14:05:27Z","lastAt":"2012-11-17T14:05:27Z","messageCount":1,"participants":["Peter Alfredsen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"203416","messageId":"CADNdRzH+Fw+LsHF4LHWm9GsKJnbHjm2SgtKvSePmpwZyT7ptMQ@mail.gmail.com","threadId":"32135","inReplyTo":null,"subject":"git-credential-gnome-keyring fails at multilib","fromName":"Peter Alfredsen","fromEmail":"peter.alfredsen@gmail.com","sentAt":"2012-11-17T14:05:27Z","receivedAt":"2012-11-17T14:05:27Z","isPatch":false,"sender":{"key":"peter.alfredsen@gmail.com","avatar":null},"body":"Downstream bug report: https://bugs.gentoo.org/443634\n\nThe git-credential-gnome-keyring Makefile doesn't allow overriding its\nvariables, making for spectacular link failure if you use CFLAGS for\naught but decoration.\n\ngcc -g -O2 -Wall   -I/usr/include/gnome-keyring-1\n-I/usr/include/glib-2.0 -I/usr/lib32/glib-2.0/include   -o\ngit-credential-gnome-keyring.o -c git-credential-gnome-keyring.c\ngcc -o git-credential-gnome-keyring -Wl,--as-needed\n-Wl,--hash-style=gnu -m32 git-credential-gnome-keyring.o\n-lgnome-keyring -lglib-2.0\n/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld:\ni386:x86-64 architecture of input file\n`git-credential-gnome-keyring.o' is incompatible with i386 output\n/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld:\ngit-credential-gnome-keyring.o: file class ELFCLASS64 incompatible\nwith ELFCLASS32\n/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.2/../../../../x86_64-pc-linux-gnu/bin/ld:\nfinal link failed: File in wrong format\ncollect2: error: ld returned 1 exit status\n\nAttached patch fixes it.\n\n/Peter\n\n\ndiff -NrU5 git-1.8.0.orig/contrib/credential/gnome-keyring/Makefile git-1.8.0/contrib/credential/gnome-keyring/Makefile\n--- git-1.8.0.orig/contrib/credential/gnome-keyring/Makefile\t2012-11-17 14:45:06.536641381 +0100\n+++ git-1.8.0/contrib/credential/gnome-keyring/Makefile\t2012-11-17 14:45:40.883442939 +0100\n@@ -1,11 +1,11 @@\n MAIN:=git-credential-gnome-keyring\n all:: $(MAIN)\n \n-CC = gcc\n-RM = rm -f\n-CFLAGS = -g -O2 -Wall\n+CC ?= gcc\n+RM ?= rm -f\n+CFLAGS ?= -g -O2 -Wall\n \n -include ../../../config.mak.autogen\n -include ../../../config.mak\n \n INCS:=$(shell pkg-config --cflags gnome-keyring-1)\n"}]}