threads / discuss / 31859

v3, 8 partsAw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

Subject: Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

## tl;dr

2 messages between Oct 18, 2012 and Oct 18, 2012. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Thomas Ackermann· Oct 18, 2012, 17:19 UTC · lore

Show 5 quoted lines

>
> That means that for the patch [6/8], which adds content-type to the
> text files, to be complete, it needs to update Makefile to produce
> html files from them.
>

IMHO also for the new files in ./technical html should be created because now as we have asciidoc markup why not also use it.

Show 6 quoted lines

>
> > BTW2: The 'pretty-print shell script in update-hook-example.txt'
> > part of my changes was left out from the merge to pu ...
> 
> Do you mean e2399e9 (Documentation/howto: convert plain text files
> to asciidoc, 2012-10-16), or something else?

Yes; in e2399e9 the following hunks where left out from the patch to update-hook-example.txt:

Show changes to diff +13 −13

@@ -111,12 +114,12 @@ then
 
       info "Found matching head pattern: '$head_pattern'"
       for user_pattern in $user_patterns; do
-	info "Checking user: '$username' against pattern: '$user_pattern'"
-	matchlen=$(expr "$username" : "$user_pattern")
-	if test "$matchlen" = "${#username}"
-	then
-	  grant "Allowing user: '$username' with pattern: '$user_pattern'"
-	fi
+        info "Checking user: '$username' against pattern: '$user_pattern'"
+        matchlen=$(expr "$username" : "$user_pattern")
+        if test "$matchlen" = "${#username}"
+        then
+          grant "Allowing user: '$username' with pattern: '$user_pattern'"
+        fi
       done
       deny "The user is not in the access list for this branch"
     done
@@ -149,13 +152,13 @@ then
 
       info "Found matching head pattern: '$head_pattern'"
       for group_pattern in $group_patterns; do
-	for groupname in $groups; do
-	  info "Checking group: '$groupname' against pattern: '$group_pattern'"
-	  matchlen=$(expr "$groupname" : "$group_pattern")
-	  if test "$matchlen" = "${#groupname}"
-	  then
-	    grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
-	  fi
+        for groupname in $groups; do
+          info "Checking group: '$groupname' against pattern: '$group_pattern'"
+          matchlen=$(expr "$groupname" : "$group_pattern")
+          if test "$matchlen" = "${#groupname}"
+          then
+            grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
+          fi
         done
       done
       deny "None of the user's groups are in the access list for this branch"



---
Thomas

Junio C Hamano· Oct 18, 2012, 20:40 UTC · re: Thomas Ackermann · lore

Re: Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files

Thomas Ackermann <th.acker66@arcor.de> writes:

Show 42 quoted lines

> Yes; in e2399e9 the following hunks where left out from the patch to update-hook-example.txt:
>
> @@ -111,12 +114,12 @@ then
>  
>        info "Found matching head pattern: '$head_pattern'"
>        for user_pattern in $user_patterns; do
> -	info "Checking user: '$username' against pattern: '$user_pattern'"
> -	matchlen=$(expr "$username" : "$user_pattern")
> -	if test "$matchlen" = "${#username}"
> -	then
> -	  grant "Allowing user: '$username' with pattern: '$user_pattern'"
> -	fi
> +        info "Checking user: '$username' against pattern: '$user_pattern'"
> +        matchlen=$(expr "$username" : "$user_pattern")
> +        if test "$matchlen" = "${#username}"
> +        then
> +          grant "Allowing user: '$username' with pattern: '$user_pattern'"
> +        fi
>        done
>        deny "The user is not in the access list for this branch"
>      done
> @@ -149,13 +152,13 @@ then
>  
>        info "Found matching head pattern: '$head_pattern'"
>        for group_pattern in $group_patterns; do
> -	for groupname in $groups; do
> -	  info "Checking group: '$groupname' against pattern: '$group_pattern'"
> -	  matchlen=$(expr "$groupname" : "$group_pattern")
> -	  if test "$matchlen" = "${#groupname}"
> -	  then
> -	    grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> -	  fi
> +        for groupname in $groups; do
> +          info "Checking group: '$groupname' against pattern: '$group_pattern'"
> +          matchlen=$(expr "$groupname" : "$group_pattern")
> +          if test "$matchlen" = "${#groupname}"
> +          then
> +            grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> +          fi
>          done
>        done
>        deny "None of the user's groups are in the access list for this branch"

Yuck. That is because I almost always apply patches with whitespace breakage fix. The above two hunks, if taken as patches to shell script, does nothing but adding whitespace breakages, turning tab indent into expanded runs of spaces, and that was why the tool dropped them.

Resurrected; will queue the result later.

Thanks.