{"thread":{"id":"31859","subject":"Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files","startedAt":"2012-10-18T17:19:52Z","lastAt":"2012-10-18T20:40:29Z","messageCount":2,"participants":["Thomas Ackermann","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":8},"messages":[{"id":"201523","messageId":"634888125.421937.1350580792693.JavaMail.ngmail@webmail11.arcor-online.net","threadId":"31859","inReplyTo":null,"subject":"Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files","fromName":"Thomas Ackermann","fromEmail":"th.acker66@arcor.de","sentAt":"2012-10-18T17:19:52Z","receivedAt":"2012-10-18T17:19:52Z","isPatch":true,"sender":{"key":"th.acker@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1358536?v=4"},"body":" \n>\n> That means that for the patch [6/8], which adds content-type to the\n> text files, to be complete, it needs to update Makefile to produce\n> html files from them.\n> \n\nIMHO also for the new files in ./technical html should be created because\nnow as we have asciidoc markup why not also use it.\n\n>\n> > BTW2: The 'pretty-print shell script in update-hook-example.txt'\n> > part of my changes was left out from the merge to pu ...\n> \n> Do you mean e2399e9 (Documentation/howto: convert plain text files\n> to asciidoc, 2012-10-16), or something else?\n\nYes; in e2399e9 the following hunks where left out from the patch to update-hook-example.txt:\n\n@@ -111,12 +114,12 @@ then\n \n       info \"Found matching head pattern: '$head_pattern'\"\n       for user_pattern in $user_patterns; do\n-\tinfo \"Checking user: '$username' against pattern: '$user_pattern'\"\n-\tmatchlen=$(expr \"$username\" : \"$user_pattern\")\n-\tif test \"$matchlen\" = \"${#username}\"\n-\tthen\n-\t  grant \"Allowing user: '$username' with pattern: '$user_pattern'\"\n-\tfi\n+        info \"Checking user: '$username' against pattern: '$user_pattern'\"\n+        matchlen=$(expr \"$username\" : \"$user_pattern\")\n+        if test \"$matchlen\" = \"${#username}\"\n+        then\n+          grant \"Allowing user: '$username' with pattern: '$user_pattern'\"\n+        fi\n       done\n       deny \"The user is not in the access list for this branch\"\n     done\n@@ -149,13 +152,13 @@ then\n \n       info \"Found matching head pattern: '$head_pattern'\"\n       for group_pattern in $group_patterns; do\n-\tfor groupname in $groups; do\n-\t  info \"Checking group: '$groupname' against pattern: '$group_pattern'\"\n-\t  matchlen=$(expr \"$groupname\" : \"$group_pattern\")\n-\t  if test \"$matchlen\" = \"${#groupname}\"\n-\t  then\n-\t    grant \"Allowing group: '$groupname' with pattern: '$group_pattern'\"\n-\t  fi\n+        for groupname in $groups; do\n+          info \"Checking group: '$groupname' against pattern: '$group_pattern'\"\n+          matchlen=$(expr \"$groupname\" : \"$group_pattern\")\n+          if test \"$matchlen\" = \"${#groupname}\"\n+          then\n+            grant \"Allowing group: '$groupname' with pattern: '$group_pattern'\"\n+          fi\n         done\n       done\n       deny \"None of the user's groups are in the access list for this branch\"\n\n\n\n---\nThomas\n"},{"id":"201525","messageId":"7vy5j3ldj6.fsf@alter.siamese.dyndns.org","threadId":"31859","inReplyTo":"634888125.421937.1350580792693.JavaMail.ngmail@webmail11.arcor-online.net","subject":"Re: Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-10-18T20:40:29Z","receivedAt":"2012-10-18T20:40:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Ackermann <th.acker66@arcor.de> writes:\n\n> Yes; in e2399e9 the following hunks where left out from the patch to update-hook-example.txt:\n>\n> @@ -111,12 +114,12 @@ then\n>  \n>        info \"Found matching head pattern: '$head_pattern'\"\n>        for user_pattern in $user_patterns; do\n> -\tinfo \"Checking user: '$username' against pattern: '$user_pattern'\"\n> -\tmatchlen=$(expr \"$username\" : \"$user_pattern\")\n> -\tif test \"$matchlen\" = \"${#username}\"\n> -\tthen\n> -\t  grant \"Allowing user: '$username' with pattern: '$user_pattern'\"\n> -\tfi\n> +        info \"Checking user: '$username' against pattern: '$user_pattern'\"\n> +        matchlen=$(expr \"$username\" : \"$user_pattern\")\n> +        if test \"$matchlen\" = \"${#username}\"\n> +        then\n> +          grant \"Allowing user: '$username' with pattern: '$user_pattern'\"\n> +        fi\n>        done\n>        deny \"The user is not in the access list for this branch\"\n>      done\n> @@ -149,13 +152,13 @@ then\n>  \n>        info \"Found matching head pattern: '$head_pattern'\"\n>        for group_pattern in $group_patterns; do\n> -\tfor groupname in $groups; do\n> -\t  info \"Checking group: '$groupname' against pattern: '$group_pattern'\"\n> -\t  matchlen=$(expr \"$groupname\" : \"$group_pattern\")\n> -\t  if test \"$matchlen\" = \"${#groupname}\"\n> -\t  then\n> -\t    grant \"Allowing group: '$groupname' with pattern: '$group_pattern'\"\n> -\t  fi\n> +        for groupname in $groups; do\n> +          info \"Checking group: '$groupname' against pattern: '$group_pattern'\"\n> +          matchlen=$(expr \"$groupname\" : \"$group_pattern\")\n> +          if test \"$matchlen\" = \"${#groupname}\"\n> +          then\n> +            grant \"Allowing group: '$groupname' with pattern: '$group_pattern'\"\n> +          fi\n>          done\n>        done\n>        deny \"None of the user's groups are in the access list for this branch\"\n\nYuck.  That is because I almost always apply patches with whitespace\nbreakage fix.  The above two hunks, if taken as patches to shell\nscript, does nothing but adding whitespace breakages, turning tab\nindent into expanded runs of spaces, and that was why the tool\ndropped them.\n\nResurrected; will queue the result later.\n\nThanks.\n"}]}