threads / patch / 31645

patchpathspec.c: Fix some sparse warnings

Subject: [PATCH] pathspec.c: Fix some sparse warnings

## tl;dr

2 messages between Sep 25, 2012 and Sep 25, 2012. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Sep 25, 2012, 17:15 UTC · lore

Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Adam,

When you re-roll your 'as/check-ignore' branch could you please squash this patch into commit a1080211 ("pathspec.c: move reusable code from builtin/add.c", 20-09-2012).

Thanks!

ATB, Ramsay Jones

 pathspec.c | 1 +
 1 file changed, 1 insertion(+)

Show changes to pathspec.c +1 −0

diff --git a/pathspec.c b/pathspec.c
index 9525c7c..5dba000 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "dir.h"
+#include "pathspec.h"
 
 void validate_path(const char *prefix, const char *path)
 {

-- 
1.7.12

Adam Spiers· Sep 25, 2012, 18:03 UTC · re: Ramsay Jones · lore

Re: [PATCH] pathspec.c: Fix some sparse warnings

On Tue, Sep 25, 2012 at 6:15 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 14 quoted lines

>
> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Adam,
>
> When you re-roll your 'as/check-ignore' branch could you please squash
> this patch into commit a1080211 ("pathspec.c: move reusable code from
> builtin/add.c", 20-09-2012).

Will do, thanks a lot!