{"thread":{"id":"31645","subject":"[PATCH] pathspec.c: Fix some sparse warnings","startedAt":"2012-09-25T17:15:41Z","lastAt":"2012-09-25T18:03:06Z","messageCount":2,"participants":["Ramsay Jones","Adam Spiers"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199898","messageId":"5061E6BD.2070109@ramsay1.demon.co.uk","threadId":"31645","inReplyTo":null,"subject":"[PATCH] pathspec.c: Fix some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-09-25T17:15:41Z","receivedAt":"2012-09-25T17:15:41Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse issues a warning for all six external symbols defined in this\nfile. In order to suppress the warnings, we include the 'pathspec.h'\nheader file, which contains the relevant extern declarations for these\nsymbols.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Adam,\n\nWhen you re-roll your 'as/check-ignore' branch could you please squash\nthis patch into commit a1080211 (\"pathspec.c: move reusable code from\nbuiltin/add.c\", 20-09-2012).\n\nThanks!\n\nATB,\nRamsay Jones\n\n pathspec.c | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/pathspec.c b/pathspec.c\nindex 9525c7c..5dba000 100644\n--- a/pathspec.c\n+++ b/pathspec.c\n@@ -1,5 +1,6 @@\n #include \"cache.h\"\n #include \"dir.h\"\n+#include \"pathspec.h\"\n \n void validate_path(const char *prefix, const char *path)\n {\n-- \n1.7.12\n"},{"id":"199900","messageId":"CAOkDyE8NGbApsF+v=UJUuaxvd9PYUfvf4yNDhNpHZ0tuqHHoBg@mail.gmail.com","threadId":"31645","inReplyTo":"5061E6BD.2070109@ramsay1.demon.co.uk","subject":"Re: [PATCH] pathspec.c: Fix some sparse warnings","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-09-25T18:03:06Z","receivedAt":"2012-09-25T18:03:06Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Tue, Sep 25, 2012 at 6:15 PM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n>\n> Sparse issues a warning for all six external symbols defined in this\n> file. In order to suppress the warnings, we include the 'pathspec.h'\n> header file, which contains the relevant extern declarations for these\n> symbols.\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Adam,\n>\n> When you re-roll your 'as/check-ignore' branch could you please squash\n> this patch into commit a1080211 (\"pathspec.c: move reusable code from\n> builtin/add.c\", 20-09-2012).\n\nWill do, thanks a lot!\n"}]}