threads / patch / 31411

patch, 6 partstest-lib.sh: Add check for invalid use of 'skip_all' facility

Subject: [PATCH 5/6] test-lib.sh: Add check for invalid use of 'skip_all' facility

## tl;dr

One message between Sep 1, 2012 and Sep 1, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Sep 1, 2012, 18:13 UTC · lore

The 'skip_all' facility cannot be used after one or more tests have been executed using (for example) 'test_expect_success'. To do so results in invalid TAP output, which leads to 'prove' complaining of "Parse errors: No plan found in TAP output".

Add a check for such invalid usage and abort the test with an error message to alert the test author.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/test-lib.sh | 4 ++++
 1 file changed, 4 insertions(+)
Show changes to t/test-lib.sh +4 −0
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 56b028c..283d27a 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -383,6 +383,10 @@ test_done () {
 	case "$test_failure" in
 	0)
 		# Maybe print SKIP message
+		if test -n "$skip_all" && test $test_count -gt 0
+		then
+			error "Can't use skip_all after running some tests"
+		fi
 		[ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"
 
 		if test $test_external_has_tap -eq 0
-- 
1.7.12

← back to recent threads