# [PATCH 5/6] test-lib.sh: Add check for invalid use of 'skip_all' facility

1 messages from 2012-09-01 to 2012-09-01. Participants: Ramsay Jones.
Thread: https://gitlist.dev/t/31411

## Ramsay Jones, 2012-09-01 18:13

Subject: [PATCH 5/6] test-lib.sh: Add check for invalid use of 'skip_all' facility
Message-ID: <5042503F.7040101@ramsay1.demon.co.uk>
URL: https://gitlist.dev/e/5042503F.7040101%40ramsay1.demon.co.uk

```

The 'skip_all' facility cannot be used after one or more tests
have been executed using (for example) 'test_expect_success'.
To do so results in invalid TAP output, which leads to 'prove'
complaining of "Parse errors: No plan found in TAP output".

Add a check for such invalid usage and abort the test with an
error message to alert the test author.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/test-lib.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 56b028c..283d27a 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -383,6 +383,10 @@ test_done () {
 	case "$test_failure" in
 	0)
 		# Maybe print SKIP message
+		if test -n "$skip_all" && test $test_count -gt 0
+		then
+			error "Can't use skip_all after running some tests"
+		fi
 		[ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"
 
 		if test $test_external_has_tap -eq 0
-- 
1.7.12

```