threads / patch / 3100

patchgit-fetch-pack: really do not ask for funny refs

Subject: [PATCH] git-fetch-pack: really do not ask for funny refs

## tl;dr

2 messages between Jan 18, 2006 and Jan 19, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Schindelin· Jan 18, 2006, 23:24 UTC · lore

If git-fetch-pack was called with out any refspec, it would ask the server for funny refs. That cannot work, since the funny refs are not marked as OUR_REF by upload-pack, which just exits with an error.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 fetch-pack.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
718ad2d76a6c7d350d63c0660aeb69518b765310
Show changes to fetch-pack.c +0 −3
diff --git a/fetch-pack.c b/fetch-pack.c
index d34f322..27f5d2a 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -262,9 +262,6 @@ static void filter_refs(struct ref **ref
 {
 	struct ref *prev, *current, *next;
 
-	if (!nr_match)
-		return;
-
 	for (prev = NULL, current = *refs; current; current = next) {
 		next = current->next;
 		if ((!memcmp(current->name, "refs/", 5) &&
-- 
1.1.3.g0bf8-dirty

← back to recent threads