# [PATCH] git-fetch-pack: really do not ask for funny refs 2 messages from 2006-01-18 to 2006-01-19. Participants: Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/3100 ## Johannes Schindelin, 2006-01-18 23:24 Subject: [PATCH] git-fetch-pack: really do not ask for funny refs Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0601190023390.15298%40wbgn013.biozentrum.uni-wuerzburg.de ``` If git-fetch-pack was called with out any refspec, it would ask the server for funny refs. That cannot work, since the funny refs are not marked as OUR_REF by upload-pack, which just exits with an error. Signed-off-by: Johannes Schindelin --- fetch-pack.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) 718ad2d76a6c7d350d63c0660aeb69518b765310 diff --git a/fetch-pack.c b/fetch-pack.c index d34f322..27f5d2a 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -262,9 +262,6 @@ static void filter_refs(struct ref **ref { struct ref *prev, *current, *next; - if (!nr_match) - return; - for (prev = NULL, current = *refs; current; current = next) { next = current->next; if ((!memcmp(current->name, "refs/", 5) && -- 1.1.3.g0bf8-dirty ``` ## Junio C Hamano, 2006-01-19 00:33 Subject: Re: [PATCH] git-fetch-pack: really do not ask for funny refs Message-ID: <7vy81drr82.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vy81drr82.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Good catch. Thanks. ```