threads / discuss / 30825

git commit-tree documentation incorrect parameter sequence

Subject: git commit-tree documentation incorrect parameter sequence

## tl;dr

3 messages between Jun 17, 2012 and Jun 20, 2012.

replies: 2people: 3as markdown or json

乙酸鋰· Jun 17, 2012, 01:57 UTC · lore

Dear Sir,

In current git commit-tree documentation, the parameter sequence is incorrect.

git commit-tree <tree> [(-p <parent>)…] < changelog git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>

The second line in incorrect, and <tree> should come first git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]

Regards, ch3cooli

Jeff King· Jun 20, 2012, 00:37 UTC · re: 乙酸鋰 · lore

Re: git commit-tree documentation incorrect parameter sequence

On Sun, Jun 17, 2012 at 09:57:42AM +0800, 乙酸鋰 wrote:

Show 8 quoted lines

> In current git commit-tree documentation,
> the parameter sequence is incorrect.
> 
> git commit-tree <tree> [(-p <parent>)…] < changelog
> git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>
> 
> The second line in incorrect, and <tree> should come first
> git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]

Yes, I believe you're right. Would you care to submit a patch?

-Peff

Junio C Hamano· Jun 20, 2012, 17:58 UTC · re: Jeff King · lore

Re: git commit-tree documentation incorrect parameter sequence

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Sun, Jun 17, 2012 at 09:57:42AM +0800, 乙酸鋰 wrote:
>
>> In current git commit-tree documentation,
>> the parameter sequence is incorrect.
>> 
>> git commit-tree <tree> [(-p <parent>)…] < changelog
>> git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>
>> 
>> The second line in incorrect, and <tree> should come first
>> git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]
>
> Yes, I believe you're right. Would you care to submit a patch?

Done as d28436736.