# git commit-tree documentation incorrect parameter sequence

3 messages from 2012-06-17 to 2012-06-20. Participants: 乙酸鋰, Jeff King, Junio C Hamano.
Thread: https://gitlist.dev/t/30825

## 乙酸鋰, 2012-06-17 01:57

Subject: git commit-tree documentation incorrect parameter sequence
Message-ID: <CAHtLG6S3ZyBV+0KxKLUSCO7yOXLGD1NGhM62sJfKPUMSeQTSoQ@mail.gmail.com>
URL: https://gitlist.dev/e/CAHtLG6S3ZyBV%2B0KxKLUSCO7yOXLGD1NGhM62sJfKPUMSeQTSoQ%40mail.gmail.com

```
Dear Sir,

In current git commit-tree documentation,
the parameter sequence is incorrect.

git commit-tree <tree> [(-p <parent>)…] < changelog
git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>

The second line in incorrect, and <tree> should come first
git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]

Regards,
ch3cooli

```

## Jeff King, 2012-06-20 00:37

Subject: Re: git commit-tree documentation incorrect parameter sequence
Message-ID: <20120620003726.GA6741@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20120620003726.GA6741%40sigill.intra.peff.net
In-Reply-To: <CAHtLG6S3ZyBV+0KxKLUSCO7yOXLGD1NGhM62sJfKPUMSeQTSoQ@mail.gmail.com>

```
On Sun, Jun 17, 2012 at 09:57:42AM +0800, 乙酸鋰 wrote:

> In current git commit-tree documentation,
> the parameter sequence is incorrect.
> 
> git commit-tree <tree> [(-p <parent>)…] < changelog
> git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>
> 
> The second line in incorrect, and <tree> should come first
> git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]

Yes, I believe you're right. Would you care to submit a patch?

-Peff

```

## Junio C Hamano, 2012-06-20 17:58

Subject: Re: git commit-tree documentation incorrect parameter sequence
Message-ID: <7va9zxx3uh.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7va9zxx3uh.fsf%40alter.siamese.dyndns.org
In-Reply-To: <20120620003726.GA6741@sigill.intra.peff.net>

```
Jeff King <peff@peff.net> writes:

> On Sun, Jun 17, 2012 at 09:57:42AM +0800, 乙酸鋰 wrote:
>
>> In current git commit-tree documentation,
>> the parameter sequence is incorrect.
>> 
>> git commit-tree <tree> [(-p <parent>)…] < changelog
>> git commit-tree [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…] <tree>
>> 
>> The second line in incorrect, and <tree> should come first
>> git commit-tree <tree> [(-p <parent>)…] [(-m <message>)…] [(-F <file>)…]
>
> Yes, I believe you're right. Would you care to submit a patch?

Done as d28436736.

```