Re: Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask

Stefan Beller· Jun 4, 2012, 20:49 UTC · lore

Hi,

I tried debugging into it:
In git/t/t1304-default-acl.sh there is:
check_perms_and_acl () {
   test -r "$1" &&
   getfacl "$1" > actual &&
   grep -q "user:root:rwx" actual &&
   grep -q "user:${LOGNAME}:rwx" actual &&
   egrep "mask::?r--" actual > /dev/null 2>&1 &&
   grep -q "group::---" actual || false
}

but when I do all the commands as in the test2:
test_expect_success SETFACL 'Objects creation does not break ACLs with
restrictive umask' '
   # SHA1 for empty blob
   check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
'
Now I run the second line in check_perms_and_acl ()  with
.git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
there is

getfacl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 # file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 # owner: sb # group: sb user::r-- user:root:rwx #effective:--- user:sb:rwx #effective:--- group::--- mask::--- other::---

This command seem to fail 'egrep "mask::?r--" actual' as there is mask::--- but expected is mask::r--

That's my understanding of the test case so far.

2012/6/4 Junio C Hamano <gitster@pobox.com>:

Show 26 quoted lines

> Stefan Beller <stefanbeller@googlemail.com> writes:
>
>> so I just pulled the new git v1.7.10.4 and tried to test it with
>>> make test
>> This yields this output:
>> stderr http://pastebin.com/V8yuZFfi
>> stdout http://dl.dropbox.com/u/6520164/git/maketest.txt
>>
>> In Test 1304 there is
>> not ok - 2 Objects creation does not break ACLs with restrictive umask
>>
>> I am running Ubuntu 12.04 with Linux sb 3.2.0-25-generic #40-Ubuntu
>> SMP Wed May 23 20:30:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
>
> Interesting. I've seen t1304 break from time to time.
>
> I set the DEFAULT_TEST_TARGET to "prove", and when the test suite
> finishes with this failure, I noticed t3600-rm and some other test I
> do not recall also failed, with two extra files (actual and expect)
> at the root of the TEST_OUTPUT_DIRECTORY (set to /dev/shm/testpen
> via "--root=/dev/shm/testpen" option).
>
> I the breakage does not happen reproducibly with any pattern other
> than the above (I do not know if it never happens when test target
> is set to "test", for example), so haven't looked (and will not
> look) into it myself further than that.