{"thread":{"id":"30709","subject":"Re: Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask","startedAt":"2012-06-04T20:49:36Z","lastAt":"2012-06-04T20:49:36Z","messageCount":1,"participants":["Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"192852","messageId":"CALbm-EYZrSU2toOOLTKTQsyT9WCejnNMGMtMYrc+Q25kTCdHaQ@mail.gmail.com","threadId":"30709","inReplyTo":null,"subject":"Re: Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask","fromName":"Stefan Beller","fromEmail":"stefanbeller@googlemail.com","sentAt":"2012-06-04T20:49:36Z","receivedAt":"2012-06-04T20:49:36Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Hi,\n\nI tried debugging into it:\nIn git/t/t1304-default-acl.sh there is:\ncheck_perms_and_acl () {\n   test -r \"$1\" &&\n   getfacl \"$1\" > actual &&\n   grep -q \"user:root:rwx\" actual &&\n   grep -q \"user:${LOGNAME}:rwx\" actual &&\n   egrep \"mask::?r--\" actual > /dev/null 2>&1 &&\n   grep -q \"group::---\" actual || false\n}\n\nbut when I do all the commands as in the test2:\ntest_expect_success SETFACL 'Objects creation does not break ACLs with\nrestrictive umask' '\n   # SHA1 for empty blob\n   check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391\n'\nNow I run the second line in check_perms_and_acl ()  with\n.git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391\nthere is\n\ngetfacl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391\n# file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391\n# owner: sb\n# group: sb\nuser::r--\nuser:root:rwx                   #effective:---\nuser:sb:rwx                     #effective:---\ngroup::---\nmask::---\nother::---\n\nThis command seem to fail 'egrep \"mask::?r--\" actual' as there is\nmask::---\nbut expected is\nmask::r--\n\nThat's my understanding of the test case so far.\n\n\n2012/6/4 Junio C Hamano <gitster@pobox.com>:\n\n> Stefan Beller <stefanbeller@googlemail.com> writes:\n>\n>> so I just pulled the new git v1.7.10.4 and tried to test it with\n>>> make test\n>> This yields this output:\n>> stderr http://pastebin.com/V8yuZFfi\n>> stdout http://dl.dropbox.com/u/6520164/git/maketest.txt\n>>\n>> In Test 1304 there is\n>> not ok - 2 Objects creation does not break ACLs with restrictive umask\n>>\n>> I am running Ubuntu 12.04 with Linux sb 3.2.0-25-generic #40-Ubuntu\n>> SMP Wed May 23 20:30:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux\n>\n> Interesting. I've seen t1304 break from time to time.\n>\n> I set the DEFAULT_TEST_TARGET to \"prove\", and when the test suite\n> finishes with this failure, I noticed t3600-rm and some other test I\n> do not recall also failed, with two extra files (actual and expect)\n> at the root of the TEST_OUTPUT_DIRECTORY (set to /dev/shm/testpen\n> via \"--root=/dev/shm/testpen\" option).\n>\n> I the breakage does not happen reproducibly with any pattern other\n> than the above (I do not know if it never happens when test target\n> is set to \"test\", for example), so haven't looked (and will not\n> look) into it myself further than that.\n"}]}