threads / patch / 30506

patch, 3 partsReduced re-roll of http-proxy-more branch

Subject: [PATCH 0/3] Reduced re-roll of http-proxy-more branch

## tl;dr

2 messages between May 11, 2012 and May 11, 2012. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Nelson Benitez Leon· May 11, 2012, 13:13 UTC · lore

Hi, based on last feedback by Junio and Jeff I've created this reduced version of http-proxy-more branch with all the bits about "reading proxy from environment" removed. When cURL adds the new api we will only need to expand the code introduced by commit 1/3 .

Regards,

Nelson Benitez Leon (3):
  http: handle proxy authentication failure (error 407)
  http: Avoid limit of retrying request only twice
  http: rename HTTP_REAUTH to HTTP_AUTH_RETRY

 http.c |   37 ++++++++++++++++++++++++++++++++-----
 http.h |    2 +-
 2 files changed, 33 insertions(+), 6 deletions(-)

-- 
1.7.7.6

Jeff King· May 11, 2012, 17:00 UTC · re: Nelson Benitez Leon · lore

Re: [PATCH 0/3] Reduced re-roll of http-proxy-more branch

On Fri, May 11, 2012 at 03:13:25PM +0200, Nelson Benitez Leon wrote:

Show 5 quoted lines

> Hi, based on last feedback by Junio and Jeff I've created this
> reduced version of http-proxy-more branch with all the bits
> about "reading proxy from environment" removed. When cURL adds
> the new api we will only need to expand the code introduced by
> commit 1/3 .

Thanks. I know it is frustrating to work on a series only to end up discarding a big chunk of it. But I think the result here makes a lot more sense in the long run.

Patches 2 and 3 look OK, but I have a few comments on the first one (I'll reply separately).

-Peff