threads / patch / 30141

patchFix a "Using plain integer as NULL pointer" sparse warning

Subject: [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning

## tl;dr

2 messages between Apr 3, 2012 and Apr 3, 2012. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Apr 3, 2012, 17:27 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Jeff,

If you need to re-roll your run-command patch [commit b0984f82, "run-command: treat inaccessible directories as ENOENT", 30-03-2012], could you please squash this patch into it. Thanks!

ATB, Ramsay Jones

 run-command.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to run-command.c +1 −1

diff --git a/run-command.c b/run-command.c
index 47afb78..ae72b9b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)
 	struct strbuf buf = STRBUF_INIT;
 
 	if (!p || !*p)
-		return 0;
+		return NULL;
 
 	while (1) {
 		const char *end = strchrnul(p, ':');

-- 
1.7.9

Jeff King· Apr 3, 2012, 20:27 UTC · re: Ramsay Jones · lore

Re: [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning

On Tue, Apr 03, 2012 at 06:27:58PM +0100, Ramsay Jones wrote:

> If you need to re-roll your run-command patch [commit b0984f82,
> "run-command: treat inaccessible directories as ENOENT", 30-03-2012],
> could you please squash this patch into it. Thanks!

I don't think it needs re-rolled, but it hasn't hit next yet. Junio, can you squash this in?

Show 10 quoted lines

> diff --git a/run-command.c b/run-command.c
> index 47afb78..ae72b9b 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)
>  	struct strbuf buf = STRBUF_INIT;
>  
>  	if (!p || !*p)
> -		return 0;
> +		return NULL;

I missed this when converting the code from "is there anything in path" to "here is what there is in path".

-Peff