{"thread":{"id":"30141","subject":"[PATCH] Fix a \"Using plain integer as NULL pointer\" sparse warning","startedAt":"2012-04-03T17:27:58Z","lastAt":"2012-04-03T20:27:06Z","messageCount":2,"participants":["Ramsay Jones","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"188424","messageId":"4F7B331E.5080604@ramsay1.demon.co.uk","threadId":"30141","inReplyTo":null,"subject":"[PATCH] Fix a \"Using plain integer as NULL pointer\" sparse warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-04-03T17:27:58Z","receivedAt":"2012-04-03T17:27:58Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Jeff,\n\nIf you need to re-roll your run-command patch [commit b0984f82,\n\"run-command: treat inaccessible directories as ENOENT\", 30-03-2012],\ncould you please squash this patch into it. Thanks!\n\nATB,\nRamsay Jones\n\n run-command.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex 47afb78..ae72b9b 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)\n \tstruct strbuf buf = STRBUF_INIT;\n \n \tif (!p || !*p)\n-\t\treturn 0;\n+\t\treturn NULL;\n \n \twhile (1) {\n \t\tconst char *end = strchrnul(p, ':');\n-- \n1.7.9\n"},{"id":"188432","messageId":"20120403202706.GA24815@sigill.intra.peff.net","threadId":"30141","inReplyTo":"4F7B331E.5080604@ramsay1.demon.co.uk","subject":"Re: [PATCH] Fix a \"Using plain integer as NULL pointer\" sparse warning","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-04-03T20:27:06Z","receivedAt":"2012-04-03T20:27:06Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Apr 03, 2012 at 06:27:58PM +0100, Ramsay Jones wrote:\n\n> If you need to re-roll your run-command patch [commit b0984f82,\n> \"run-command: treat inaccessible directories as ENOENT\", 30-03-2012],\n> could you please squash this patch into it. Thanks!\n\nI don't think it needs re-rolled, but it hasn't hit next yet. Junio, can\nyou squash this in?\n\n> diff --git a/run-command.c b/run-command.c\n> index 47afb78..ae72b9b 100644\n> --- a/run-command.c\n> +++ b/run-command.c\n> @@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)\n>  \tstruct strbuf buf = STRBUF_INIT;\n>  \n>  \tif (!p || !*p)\n> -\t\treturn 0;\n> +\t\treturn NULL;\n\nI missed this when converting the code from \"is there anything in path\"\nto \"here is what there is in path\".\n\n-Peff\n"}]}