git://github.com/some/thing.git/?

I just noticed that

	git ls-remote git://repo.or.cz/alt-git.git/

works, but neither of the following does:

	git ls-remote git://git://github.com/gitster/git.git/
	git ls-remote git://git://github.com/gitster/git/

It is just a minor irritation but it would be really nice if you can fix it (please don't spend too much time on it if it is too involved, though).

On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:

Of course they don't work, they are malformed. :)

It took me a minute to figure it out, but I assume the interesting part is the trailing slash?

Interestingly, this does work for http URLs, because we do some normalization on the client side (and then append things like "info/refs"). I wonder if we should do similar normalization for other protocols.

Even with that, though, I think it would be good for the server to be liberal in what it accepts.

-Peff

Jeff King <peff@peff.net> writes:

Ahh, drop the duplicated "git://" from the front.

Yes.

It is not about being liberal; it is about accepting what we have always accepted.

On Tue, Mar 27, 2012 at 11:25:22AM -0700, Junio C Hamano wrote:

For some definition of "we"; AFAICT, github has never allowed this, and this is the first complaint (we run a stock git-daemon, but our forwarding proxies are picky about getting real "user/project" style paths, since they need them to route to the correct backends).

However, it turned out to be a one-line patch. I've pushed it out for review by other GitHubbers. The last thing the world needs is me deploying anything to a live website.

-Peff

Jeff King wrote:

I complained and got a dismissive response about two years ago. ;-) I am not sure if bugs from back then are tracked any more. The URL in my records is [1].

[...]

Hoorah!  Thanks for taking care of it.

Sincerely, Jonathan

[1] http://support.github.com/discussions/repos/3046-cannot-access-repository-using-url-with-trailing-slash-is-not-a-valid-repository-name

On Tue, Mar 27, 2012 at 01:47:54PM -0500, Jonathan Nieder wrote:

I wasn't able to find the original discussion, as we've migrated through a few different support systems in the last few years. Probably it is in there somewhere, but I don't usually do support stuff, and I didn't think it was worth bothering the regular support people with it.

FYI, this is now deployed, and the various front-end machines are getting updated slowly over the next few hours (until then, it's non-deterministic whether it will work for you or not :) ).

-Peff

Jeff King <peff@peff.net> writes:

Thanks.

I'm not sure if it's intentional, but notice that 'git://' is repeated in each of the urls that don't work. If I fix it for the last one, it does work.

On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote: