{"thread":{"id":"30073","subject":"git://github.com/some/thing.git/?","startedAt":"2012-03-27T15:46:42Z","lastAt":"2012-03-28T04:28:26Z","messageCount":8,"participants":["Junio C Hamano","Jeff King","Kevin","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"187861","messageId":"7vpqbyjbbx.fsf@alter.siamese.dyndns.org","threadId":"30073","inReplyTo":null,"subject":"git://github.com/some/thing.git/?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-27T15:46:42Z","receivedAt":"2012-03-27T15:46:42Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I just noticed that\n\n\tgit ls-remote git://repo.or.cz/alt-git.git/\n\nworks, but neither of the following does:\n\n\tgit ls-remote git://git://github.com/gitster/git.git/\n\tgit ls-remote git://git://github.com/gitster/git/\n\nIt is just a minor irritation but it would be really nice if you can fix\nit (please don't spend too much time on it if it is too involved, though).\n"},{"id":"187864","messageId":"20120327163339.GA5941@sigill.intra.peff.net","threadId":"30073","inReplyTo":"7vpqbyjbbx.fsf@alter.siamese.dyndns.org","subject":"Re: git://github.com/some/thing.git/?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-03-27T16:33:39Z","receivedAt":"2012-03-27T16:33:39Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:\n\n> I just noticed that\n> \n> \tgit ls-remote git://repo.or.cz/alt-git.git/\n> \n> works, but neither of the following does:\n> \n> \tgit ls-remote git://git://github.com/gitster/git.git/\n> \tgit ls-remote git://git://github.com/gitster/git/\n> \n> It is just a minor irritation but it would be really nice if you can fix\n> it (please don't spend too much time on it if it is too involved, though).\n\nOf course they don't work, they are malformed. :)\n\nIt took me a minute to figure it out, but I assume the interesting part\nis the trailing slash?\n\nInterestingly, this does work for http URLs, because we do some\nnormalization on the client side (and then append things like\n\"info/refs\"). I wonder if we should do similar normalization for other\nprotocols.\n\nEven with that, though, I think it would be good for the server to be\nliberal in what it accepts.\n\n-Peff\n"},{"id":"187872","messageId":"20120327175450.GA2478@ikke-laptop.lokaal","threadId":"30073","inReplyTo":"7vpqbyjbbx.fsf@alter.siamese.dyndns.org","subject":"Re: git://github.com/some/thing.git/?","fromName":"Kevin","fromEmail":"compufreak@gmail.com","sentAt":"2012-03-27T17:54:50Z","receivedAt":"2012-03-27T17:54:50Z","isPatch":false,"sender":{"key":"compufreak@gmail.com","avatar":"https://gravatar.com/avatar/10ca3ab6beccce3bbb196f655727a5ece331d2c95062270ef9d52e64f0d9356b?d=mp&s=160"},"body":"I'm not sure if it's intentional, but notice that 'git://' is repeated in\neach of the urls that don't work. If I fix it for the last one, it does\nwork.\n\nOn Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:\n> I just noticed that\n> \n> \tgit ls-remote git://repo.or.cz/alt-git.git/\n> \n> works, but neither of the following does:\n> \n> \tgit ls-remote git://git://github.com/gitster/git.git/\n> \tgit ls-remote git://git://github.com/gitster/git/\n> \n> It is just a minor irritation but it would be really nice if you can fix\n> it (please don't spend too much time on it if it is too involved, though).\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"},{"id":"187878","messageId":"7vd37xj3zh.fsf@alter.siamese.dyndns.org","threadId":"30073","inReplyTo":"20120327163339.GA5941@sigill.intra.peff.net","subject":"Re: git://github.com/some/thing.git/?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-27T18:25:22Z","receivedAt":"2012-03-27T18:25:22Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:\n>\n>> I just noticed that\n>> \n>> \tgit ls-remote git://repo.or.cz/alt-git.git/\n>> \n>> works, but neither of the following does:\n>> \n>> \tgit ls-remote git://git://github.com/gitster/git.git/\n>> \tgit ls-remote git://git://github.com/gitster/git/\n>> \n>> It is just a minor irritation but it would be really nice if you can fix\n>> it (please don't spend too much time on it if it is too involved, though).\n>\n> Of course they don't work, they are malformed. :)\n\nAhh, drop the duplicated \"git://\" from the front.\n\n> It took me a minute to figure it out, but I assume the interesting part\n> is the trailing slash?\n\nYes.\n\n> Even with that, though, I think it would be good for the server to be\n> liberal in what it accepts.\n\nIt is not about being liberal; it is about accepting what we have always\naccepted.\n"},{"id":"187880","messageId":"20120327183833.GB8460@sigill.intra.peff.net","threadId":"30073","inReplyTo":"7vd37xj3zh.fsf@alter.siamese.dyndns.org","subject":"Re: git://github.com/some/thing.git/?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-03-27T18:38:33Z","receivedAt":"2012-03-27T18:38:33Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Mar 27, 2012 at 11:25:22AM -0700, Junio C Hamano wrote:\n\n> > Even with that, though, I think it would be good for the server to be\n> > liberal in what it accepts.\n> \n> It is not about being liberal; it is about accepting what we have always\n> accepted.\n\nFor some definition of \"we\"; AFAICT, github has never allowed this, and\nthis is the first complaint (we run a stock git-daemon, but our forwarding\nproxies are picky about getting real \"user/project\" style paths, since\nthey need them to route to the correct backends).\n\nHowever, it turned out to be a one-line patch. I've pushed it out for\nreview by other GitHubbers. The last thing the world needs is me\ndeploying anything to a live website.\n\n-Peff\n"},{"id":"187882","messageId":"20120327184754.GA27070@burratino","threadId":"30073","inReplyTo":"20120327183833.GB8460@sigill.intra.peff.net","subject":"Re: git://github.com/some/thing.git/?","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-03-27T18:47:54Z","receivedAt":"2012-03-27T18:47:54Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jeff King wrote:\n\n> For some definition of \"we\"; AFAICT, github has never allowed this, and\n> this is the first complaint\n\nI complained and got a dismissive response about two years ago. ;-)  I\nam not sure if bugs from back then are tracked any more.  The URL in\nmy records is [1].\n\n[...]\n> However, it turned out to be a one-line patch. I've pushed it out for\n> review by other GitHubbers.\n\nHoorah!  Thanks for taking care of it.\n\nSincerely,\nJonathan\n\n[1] http://support.github.com/discussions/repos/3046-cannot-access-repository-using-url-with-trailing-slash-is-not-a-valid-repository-name\n"},{"id":"187883","messageId":"7v8vilj2m5.fsf@alter.siamese.dyndns.org","threadId":"30073","inReplyTo":"20120327183833.GB8460@sigill.intra.peff.net","subject":"Re: git://github.com/some/thing.git/?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-27T18:54:58Z","receivedAt":"2012-03-27T18:54:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> However, it turned out to be a one-line patch.\n\nThanks.\n"},{"id":"187911","messageId":"20120328042826.GC30251@sigill.intra.peff.net","threadId":"30073","inReplyTo":"20120327184754.GA27070@burratino","subject":"Re: git://github.com/some/thing.git/?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-03-28T04:28:26Z","receivedAt":"2012-03-28T04:28:26Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Mar 27, 2012 at 01:47:54PM -0500, Jonathan Nieder wrote:\n\n> > For some definition of \"we\"; AFAICT, github has never allowed this, and\n> > this is the first complaint\n> \n> I complained and got a dismissive response about two years ago. ;-)  I\n> am not sure if bugs from back then are tracked any more.  The URL in\n> my records is [1].\n\nI wasn't able to find the original discussion, as we've migrated through\na few different support systems in the last few years. Probably it is in\nthere somewhere, but I don't usually do support stuff, and I didn't\nthink it was worth bothering the regular support people with it.\n\n> > However, it turned out to be a one-line patch. I've pushed it out for\n> > review by other GitHubbers.\n> \n> Hoorah!  Thanks for taking care of it.\n\nFYI, this is now deployed, and the various front-end machines are\ngetting updated slowly over the next few hours (until then, it's\nnon-deterministic whether it will work for you or not :) ).\n\n-Peff\n"}]}