[PATCH] clone: don't say <branch> when we mean <remote>

Carlos Martín Nieto· Dec 21, 2011, 18:14 UTC · lore

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---

The manpage says <name> which might actually be a better word to use everywhere, but having <branch> instead of <remote> can only lead to confusion.

Looking through blame, the second line survived a typo fix and was introduced in 2008 when clone was made a builtin. The script used to say <name>. So it's clearly nothing urgent, but it bugged me, so I'm sending a patch.

 builtin/clone.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to builtin/clone.c +2 −2

diff --git a/builtin/clone.c b/builtin/clone.c
index efe8b6c..e85ee69 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -84,8 +84,8 @@ static struct option builtin_clone_options[] = {
 		   "directory from which templates will be used"),
 	OPT_CALLBACK(0 , "reference", &option_reference, "repo",
 		     "reference repository", &opt_parse_reference),
-	OPT_STRING('o', "origin", &option_origin, "branch",
-		   "use <branch> instead of 'origin' to track upstream"),
+	OPT_STRING('o', "origin", &option_origin, "remote",
+		   "use <remote> instead of 'origin' to track upstream"),
 	OPT_STRING('b', "branch", &option_branch, "branch",
 		   "checkout <branch> instead of the remote's HEAD"),
 	OPT_STRING('u', "upload-pack", &option_upload_pack, "path",

-- 
1.7.8.352.g876a6f

Junio C Hamano· Dec 21, 2011, 19:25 UTC · re: Carlos Martín Nieto · lore

Re: [PATCH] clone: don't say <branch> when we mean <remote>

Carlos Martín Nieto <cmn@elego.de> writes:

> Looking through blame, the second line survived a typo fix and was
> introduced in 2008 when clone was made a builtin. The script used to
> say <name>. So it's clearly nothing urgent, but it bugged me, so I'm
> sending a patch.

Thanks.

How I hated these "rewrite in C" now comes back piece by piece, trickling in. That's the price of progress, I guess.

patchclone: don't say <branch> when we mean <remote>