{"thread":{"id":"29231","subject":"[PATCH] clone: don't say <branch> when we mean <remote>","startedAt":"2011-12-21T18:14:09Z","lastAt":"2011-12-21T19:25:13Z","messageCount":2,"participants":["Carlos Martín Nieto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"181585","messageId":"1324491249-5357-1-git-send-email-cmn@elego.de","threadId":"29231","inReplyTo":null,"subject":"[PATCH] clone: don't say <branch> when we mean <remote>","fromName":"Carlos Martín Nieto","fromEmail":"cmn@elego.de","sentAt":"2011-12-21T18:14:09Z","receivedAt":"2011-12-21T18:14:09Z","isPatch":true,"sender":{"key":"cmn@elego.de","avatar":"https://avatars.githubusercontent.com/u/335443?v=4"},"body":"Signed-off-by: Carlos Martín Nieto <cmn@elego.de>\n---\n\nThe manpage says <name> which might actually be a better word to use\neverywhere, but having <branch> instead of <remote> can only lead to\nconfusion.\n\nLooking through blame, the second line survived a typo fix and was\nintroduced in 2008 when clone was made a builtin. The script used to\nsay <name>. So it's clearly nothing urgent, but it bugged me, so I'm\nsending a patch.\n\n builtin/clone.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex efe8b6c..e85ee69 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -84,8 +84,8 @@ static struct option builtin_clone_options[] = {\n \t\t   \"directory from which templates will be used\"),\n \tOPT_CALLBACK(0 , \"reference\", &option_reference, \"repo\",\n \t\t     \"reference repository\", &opt_parse_reference),\n-\tOPT_STRING('o', \"origin\", &option_origin, \"branch\",\n-\t\t   \"use <branch> instead of 'origin' to track upstream\"),\n+\tOPT_STRING('o', \"origin\", &option_origin, \"remote\",\n+\t\t   \"use <remote> instead of 'origin' to track upstream\"),\n \tOPT_STRING('b', \"branch\", &option_branch, \"branch\",\n \t\t   \"checkout <branch> instead of the remote's HEAD\"),\n \tOPT_STRING('u', \"upload-pack\", &option_upload_pack, \"path\",\n-- \n1.7.8.352.g876a6f\n"},{"id":"181596","messageId":"7vwr9pg21y.fsf@alter.siamese.dyndns.org","threadId":"29231","inReplyTo":"1324491249-5357-1-git-send-email-cmn@elego.de","subject":"Re: [PATCH] clone: don't say <branch> when we mean <remote>","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-12-21T19:25:13Z","receivedAt":"2011-12-21T19:25:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlos Martín Nieto <cmn@elego.de> writes:\n\n> Looking through blame, the second line survived a typo fix and was\n> introduced in 2008 when clone was made a builtin. The script used to\n> say <name>. So it's clearly nothing urgent, but it bugged me, so I'm\n> sending a patch.\n\nThanks.\n\nHow I hated these \"rewrite in C\" now comes back piece by piece, trickling\nin. That's the price of progress, I guess.\n"}]}