threads / patch / 29066

patchAdd MYMETA.yml to perl/.gitignore

Subject: [PATCH] Add MYMETA.yml to perl/.gitignore

## tl;dr

5 messages between Dec 1, 2011 and Dec 3, 2011. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Sebastian Morr· Dec 1, 2011, 20:31 UTC · lore

This file is auto-generated in the process of building the Perl extension.

Signed-off-by: Sebastian Morr <sebastian@morr.cc>
---
Good day, fine Sirs and Madams,

I just built Git for the first time, issued "git status", and there was this untracked file. I guess you could call that an itch. This patch fixes that, however, I'm not sure whether this is a relevant issue.

Didn't know whom to Cc, as the perl directory doesn't seem to get much attention lately.

Kind regards, Sebastian

 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to perl/.gitignore +1 −0
diff --git a/perl/.gitignore b/perl/.gitignore
index 98b2477..9235e73 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.yml
 blib
 blibdirs
 pm_to_blib

-- 
1.7.8.rc4.dirty
Jeff King· Dec 1, 2011, 22:35 UTC · re: Sebastian Morr · lore

Re: [PATCH] Add MYMETA.yml to perl/.gitignore

On Thu, Dec 01, 2011 at 09:31:15PM +0100, Sebastian Morr wrote:
Show 8 quoted lines
> This file is auto-generated in the process of building the Perl
> extension.
>
> [...]
> 
> I just built Git for the first time, issued "git status", and there
> was this untracked file. I guess you could call that an itch. This patch
> fixes that, however, I'm not sure whether this is a relevant issue.

Thanks, I wrote the same patch myself last week. I could swear I sent it to the list, but it appears that I forgot.

The only thing I would add is the reason this is suddenly coming up now: generating MYMETA.yml is done only by new-ish versions of ExtUtils::MakeMaker (it started for me with perl 5.14, which just hit debian unstable recently). The file just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

-Peff
Sebastian Morr· Dec 2, 2011, 22:55 UTC · re: Jeff King · lore

[PATCH v2] Add MYMETA.yml to perl/.gitignore

This file is auto-generated by newer versions of ExtUtils::MakeMaker (presumably starting with the version shipping with Perl 5.14). It just contains extra information about the environment and arguments to the Makefile-building process, and can be safely deleted.

Signed-off-by: Sebastian Morr <sebastian@morr.cc>
---
 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to perl/.gitignore +1 −0
diff --git a/perl/.gitignore b/perl/.gitignore
index 98b2477..9235e73 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.yml
 blib
 blibdirs
 pm_to_blib

-- 
1.7.8.rc4.dirty
Junio C Hamano· Dec 2, 2011, 23:41 UTC · re: Sebastian Morr · lore

Re: [PATCH v2] Add MYMETA.yml to perl/.gitignore

Sebastian Morr <sebastian@morr.cc> writes:
> This file is auto-generated by newer versions of ExtUtils::MakeMaker
> (presumably starting with the version shipping with Perl 5.14). It just
> contains extra information about the environment and arguments to the
> Makefile-building process, and can be safely deleted.

"safely deleted" sounds as if you made "make clean" remove it. I do not mind doing s/and can be.*/and should be ignored./ myself, if you want.

Does running "make clean" actually remove it, by the way?
Show 16 quoted lines
> Signed-off-by: Sebastian Morr <sebastian@morr.cc>
> ---
>  perl/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/perl/.gitignore b/perl/.gitignore
> index 98b2477..9235e73 100644
> --- a/perl/.gitignore
> +++ b/perl/.gitignore
> @@ -1,5 +1,6 @@
>  perl.mak
>  perl.mak.old
> +MYMETA.yml
>  blib
>  blibdirs
>  pm_to_blib
Sebastian Morr· Dec 3, 2011, 00:07 UTC · re: Junio C Hamano · lore

Re: [PATCH v2] Add MYMETA.yml to perl/.gitignore

On Fri, Dec 02, 2011 at 03:41:24PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Sebastian Morr <sebastian@morr.cc> writes:
> 
> > This file is auto-generated by newer versions of ExtUtils::MakeMaker
> > (presumably starting with the version shipping with Perl 5.14). It just
> > contains extra information about the environment and arguments to the
> > Makefile-building process, and can be safely deleted.
> 
> "safely deleted" sounds as if you made "make clean" remove it.  I do not
> mind doing s/and can be.*/and should be ignored./ myself, if you want.
You're very welcome to do that.
> Does running "make clean" actually remove it, by the way?

Yes, it does. perl/perl.mak (which, in turn, is generated by MakeMaker via perl/Makefile) takes care of that file explicitly.

← back to recent threads