threads / discuss / 29024

gitweb: 404 links on some blob pages

Subject: gitweb: 404 links on some blob pages

## tl;dr

3 messages between Nov 27, 2011 and Nov 28, 2011.

replies: 2people: 2as markdown or json

Jürgen Kreileder· Nov 27, 2011, 04:03 UTC · lore

Hi,

some blob pages have broken links:

For example, on https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a the blob_plain link for WindowController.m leads to '404 - Cannot find file': https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a

And the tree link for "[contactalbum.git]" leads to '404 - Reading tree failed': https://git.blackdown.de/?p=contactalbum.git;a=tree;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a

Here's a page from git.kernel.org which shows exactly the same problem: http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=blob;f=drivers/Makefile;h=91077ac6b1564a21449a155cde1b84d6678d6e13;hb=91077ac6b1564a21449a155cde1b84d6678d6e13

Jürgen

-- http://blog.blackdown.de/ http://www.flickr.com/photos/jkreileder/

Jakub Narebski· Nov 27, 2011, 22:44 UTC · re: Jürgen Kreileder · lore

Re: gitweb: 404 links on some blob pages

Jürgen Kreileder <jk@blackdown.de> writes:

Show 6 quoted lines

> some blob pages have broken links:
> 
> For example, on
> https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a
> the blob_plain link for WindowController.m leads to '404 - Cannot find file':
> https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a

That is strange. The check is the same for 'blob' and 'blob_plain' action...

-- 
Jakub Narębski

Jakub Narebski· Nov 28, 2011, 17:24 UTC · lore

Re: gitweb: 404 links on some blob pages

Jürgen Kreileder wrote:

Show 16 quoted lines

> 2011/11/27 Jakub Narebski <jnareb@gmail.com>:
> > Jürgen Kreileder <jk@blackdown.de> writes:
> >
> > > some blob pages have broken links:
> > >
> > > For example, on
> > > https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a
> > > the blob_plain link for WindowController.m leads to '404 - Cannot find file':
> > > https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a
> >
> > That is strange.  The check is the same for 'blob' and 'blob_plain'
> > action...
> 
> The problem is the missing hash (h) parameter for the latter URL.
> Adding it to the blob_plain link makes it work.  Just as removing it
> from the blob link breaks that one as well.

Strange. From the look of the page it looks like the 'hb' ("hash_base") parameter that should lead to the commit from which we get the file is bogus.

But the "raw" link uses

  href(action=>"blob_plain", -replay=>1)

which means that if 'blob' has "h" set correctly, then 'blob_plain' should too.

> Adding h=... to the tree link doesn't fix that case, though.

Of course it doesn't if you just copy _blob_ hash as _tree_ hash... :-P (i.e. if you just copy "h" parameter from 'blob' URL).

-- 
Jakub Narebski
Poland