{"thread":{"id":"29024","subject":"gitweb: 404 links on some blob pages","startedAt":"2011-11-27T04:03:30Z","lastAt":"2011-11-28T17:24:53Z","messageCount":3,"participants":["Jürgen Kreileder","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"179998","messageId":"CAKD0UuxBO_Uj4dHr9g3zryO=03_ds0omFFnGY89_MPJGfxLZMA@mail.gmail.com","threadId":"29024","inReplyTo":null,"subject":"gitweb: 404 links on some blob pages","fromName":"Jürgen Kreileder","fromEmail":"jk@blackdown.de","sentAt":"2011-11-27T04:03:30Z","receivedAt":"2011-11-27T04:03:30Z","isPatch":false,"sender":{"key":"jk@blackdown.de","avatar":"https://avatars.githubusercontent.com/u/4390544?v=4"},"body":"Hi,\n\nsome blob pages have broken links:\n\nFor example, on\nhttps://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\nthe blob_plain link for WindowController.m leads to '404 - Cannot find file':\nhttps://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n\nAnd the tree link for \"[contactalbum.git]\" leads to '404 - Reading tree failed':\nhttps://git.blackdown.de/?p=contactalbum.git;a=tree;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n\nHere's a page from git.kernel.org which shows exactly the same problem:\nhttp://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=blob;f=drivers/Makefile;h=91077ac6b1564a21449a155cde1b84d6678d6e13;hb=91077ac6b1564a21449a155cde1b84d6678d6e13\n\n\nJürgen\n\n--\nhttp://blog.blackdown.de/\nhttp://www.flickr.com/photos/jkreileder/\n"},{"id":"180026","messageId":"m3y5v1kwwm.fsf@localhost.localdomain","threadId":"29024","inReplyTo":"CAKD0UuxBO_Uj4dHr9g3zryO=03_ds0omFFnGY89_MPJGfxLZMA@mail.gmail.com","subject":"Re: gitweb: 404 links on some blob pages","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-11-27T22:44:23Z","receivedAt":"2011-11-27T22:44:23Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jürgen Kreileder <jk@blackdown.de> writes:\n\n> some blob pages have broken links:\n> \n> For example, on\n> https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n> the blob_plain link for WindowController.m leads to '404 - Cannot find file':\n> https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n\nThat is strange.  The check is the same for 'blob' and 'blob_plain'\naction...\n\n-- \nJakub Narębski\n"},{"id":"180053","messageId":"201111281824.53338.jnareb@gmail.com","threadId":"29024","inReplyTo":"CAKD0Uuyom0chUGfsh+oBRw8NoH4XutbmkVVKoQon6YO2V5oWkA@mail.gmail.com","subject":"Re: gitweb: 404 links on some blob pages","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-11-28T17:24:53Z","receivedAt":"2011-11-28T17:24:53Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jürgen Kreileder wrote:\n> 2011/11/27 Jakub Narebski <jnareb@gmail.com>:\n> > Jürgen Kreileder <jk@blackdown.de> writes:\n> >\n> > > some blob pages have broken links:\n> > >\n> > > For example, on\n> > > https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n> > > the blob_plain link for WindowController.m leads to '404 - Cannot find file':\n> > > https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a\n> >\n> > That is strange.  The check is the same for 'blob' and 'blob_plain'\n> > action...\n> \n> The problem is the missing hash (h) parameter for the latter URL.\n> Adding it to the blob_plain link makes it work.  Just as removing it\n> from the blob link breaks that one as well.\n\nStrange.  From the look of the page it looks like the 'hb' (\"hash_base\")\nparameter that should lead to the commit from which we get the file is\nbogus.\n\nBut the \"raw\" link uses \n\n  href(action=>\"blob_plain\", -replay=>1)\n\nwhich means that if 'blob' has \"h\" set correctly, then 'blob_plain'\nshould too.\n\n> Adding h=... to the tree link doesn't fix that case, though.\n\nOf course it doesn't if you just copy _blob_ hash as _tree_ hash... :-P\n(i.e. if you just copy \"h\" parameter from 'blob' URL).\n\n-- \nJakub Narebski\nPoland\n"}]}