threads / patch / 27950

patchpull: remove extra space from reflog message

Subject: [PATCH] pull: remove extra space from reflog message

## tl;dr

2 messages between Jul 29, 2011 and Aug 1, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ori Avtalion· Jul 29, 2011, 07:19 UTC · lore

When executing "git pull" with no arguments, the reflog message was:
  "pull : Fast-forward"

Signed-off-by: Ori Avtalion <ori@avtalion.name>
---

This is a correction of my earlier patch, based on the suggestion by Andreas Schwab

 git-pull.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-pull.sh +1 −1

diff --git a/git-pull.sh b/git-pull.sh
index a10b129..eec3a07 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -10,7 +10,7 @@ SUBDIRECTORY_OK=Yes
 OPTIONS_SPEC=
 . git-sh-setup
 . git-sh-i18n
-set_reflog_action "pull $*"
+set_reflog_action "pull${1+ $*}"
 require_work_tree
 cd_to_toplevel

-- 
1.7.4.1

Junio C Hamano· Aug 1, 2011, 23:04 UTC · re: Ori Avtalion · lore

Re: [PATCH] pull: remove extra space from reflog message

Ori Avtalion <ori@avtalion.name> writes:

Show 24 quoted lines

> When executing "git pull" with no arguments, the reflog message was:
>   "pull : Fast-forward"
>
> Signed-off-by: Ori Avtalion <ori@avtalion.name>
> ---
>
> This is a correction of my earlier patch, based on the suggestion
> by Andreas Schwab
>
>  git-pull.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-pull.sh b/git-pull.sh
> index a10b129..eec3a07 100755
> --- a/git-pull.sh
> +++ b/git-pull.sh
> @@ -10,7 +10,7 @@ SUBDIRECTORY_OK=Yes
>  OPTIONS_SPEC=
>  . git-sh-setup
>  . git-sh-i18n
> -set_reflog_action "pull $*"
> +set_reflog_action "pull${1+ $*}"
>  require_work_tree
>  cd_to_toplevel

Thanks, will queue.

I wonder if we have any test in the contents of the reflog messages, though.