# [PATCH] pull: remove extra space from reflog message 2 messages from 2011-07-29 to 2011-08-01. Participants: Ori Avtalion, Junio C Hamano. Thread: https://gitlist.dev/t/27950 ## Ori Avtalion, 2011-07-29 07:19 Subject: [PATCH] pull: remove extra space from reflog message Message-ID: <4e3260f8.41d0e30a.741c.51cb@mx.google.com> URL: https://gitlist.dev/e/4e3260f8.41d0e30a.741c.51cb%40mx.google.com ``` When executing "git pull" with no arguments, the reflog message was: "pull : Fast-forward" Signed-off-by: Ori Avtalion --- This is a correction of my earlier patch, based on the suggestion by Andreas Schwab git-pull.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-pull.sh b/git-pull.sh index a10b129..eec3a07 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -10,7 +10,7 @@ SUBDIRECTORY_OK=Yes OPTIONS_SPEC= . git-sh-setup . git-sh-i18n -set_reflog_action "pull $*" +set_reflog_action "pull${1+ $*}" require_work_tree cd_to_toplevel -- 1.7.4.1 ``` ## Junio C Hamano, 2011-08-01 23:04 Subject: Re: [PATCH] pull: remove extra space from reflog message Message-ID: <7vk4awhgxz.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk4awhgxz.fsf%40alter.siamese.dyndns.org In-Reply-To: <4e3260f8.41d0e30a.741c.51cb@mx.google.com> ``` Ori Avtalion writes: > When executing "git pull" with no arguments, the reflog message was: > "pull : Fast-forward" > > Signed-off-by: Ori Avtalion > --- > > This is a correction of my earlier patch, based on the suggestion > by Andreas Schwab > > git-pull.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/git-pull.sh b/git-pull.sh > index a10b129..eec3a07 100755 > --- a/git-pull.sh > +++ b/git-pull.sh > @@ -10,7 +10,7 @@ SUBDIRECTORY_OK=Yes > OPTIONS_SPEC= > . git-sh-setup > . git-sh-i18n > -set_reflog_action "pull $*" > +set_reflog_action "pull${1+ $*}" > require_work_tree > cd_to_toplevel Thanks, will queue. I wonder if we have any test in the contents of the reflog messages, though. ```