threads / patch / 27613

patchstgit.el: Stop "Summary:" being added to all commit msgs.

Subject: [stgit PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.

## tl;dr

3 messages between Jun 13, 2011 and Jun 13, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Peter TB Brett· Jun 13, 2011, 08:37 UTC · lore

In Emacs 23.3.1, if `log-edit' is called with a non-nil `setup' argument, it unconditionally appends "Summary:" to the log buffer. It causes great annoyance to have to remember to find and delete this string on every patch commit message edit with stgit-mode. This patch makes `stgit-edit' call `log-edit' with a nil `setup' argument.

Did I mention that this is *incredibly annoying*?

See also https://gna.org/bugs/?18206

Peter

-- 
Peter Brett <peter@peter-b.co.uk>
Remote Sensing Research Group
Surrey Space Centre

From 4cdf9770144933c5cd2b0399cc084841c1d5c46d Mon Sep 17 00:00:00 2001
From: Peter TB Brett <peter@peter-b.co.uk>
Date: Mon, 13 Jun 2011 09:33:12 +0100
Subject: [PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.

In Emacs 23.3.1, if `log-edit' is called with a non-nil `setup'
argument, it unconditionally appends "Summary:" to the log buffer.  It
causes great annoyance to have to remember to find and delete this
string on every patch commit message edit with stgit-mode.  This patch
makes `stgit-edit' call `log-edit' with a nil `setup' argument.

Signed-off-by: Peter TB Brett <peter@peter-b.co.uk>
---
 contrib/stgit.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/stgit.el b/contrib/stgit.el
index c71df4b..f640e5e 100644
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -2298,7 +2298,7 @@ file ended up. You can then jump to the file with \
   (let ((patchsym (stgit-patch-name-at-point t t))
         (edit-buf (get-buffer-create "*StGit edit*"))
         (dir default-directory))
-    (log-edit 'stgit-confirm-edit t nil edit-buf)
+    (log-edit 'stgit-confirm-edit nil nil edit-buf)
     (set (make-local-variable 'stgit-edit-patchsym) patchsym)
     (setq default-directory dir)
     (let ((standard-output edit-buf))
-- 
1.7.6.rc1

Gustav Hållberg· Jun 13, 2011, 09:11 UTC · re: Peter TB Brett · lore

Re: [stgit PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.

On Mon, Jun 13, 2011 at 10:37 AM, Peter TB Brett <peter@peter-b.co.uk> wrote:

> Did I mention that this is *incredibly annoying*?

I couldn't agree more, but if this is how all now-poor Emacs users will expect log-edit to behave, maybe we ought to follow suit with respect to adding christmas-tree-lit standard headers and such. For sure, your patch improves the current situation which is broken, but it's quite different from how git-status does it for example…

- Gustav

Peter TB Brett· Jun 13, 2011, 09:44 UTC · re: Gustav Hållberg · lore

Re: [stgit PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.

On Mon, 13 Jun 2011 11:11:08 +0200, Gustav Hållberg <gustav@gmail.com> wrote:

Show 9 quoted lines

> On Mon, Jun 13, 2011 at 10:37 AM, Peter TB Brett <peter@peter-b.co.uk>
> wrote:
>> Did I mention that this is *incredibly annoying*?
> 
> I couldn't agree more, but if this is how all now-poor Emacs users
> will expect log-edit to behave, maybe we ought to follow suit with
> respect to adding christmas-tree-lit standard headers and such.
> For sure, your patch improves the current situation which is broken,
> but it's quite different from how git-status does it for example…

Okay. The patch has another bug in that it causes the *previous* message edited to get appended instead (WTF?) so please disregard this for now.

Is it possible to borrow the code from git.el?

Peter

-- 
Peter Brett <peter@peter-b.co.uk>
Remote Sensing Research Group
Surrey Space Centre