{"thread":{"id":"27613","subject":"[stgit PATCH] stgit.el: Stop \"Summary:\" being added to all commit msgs.","startedAt":"2011-06-13T08:37:26Z","lastAt":"2011-06-13T09:44:49Z","messageCount":3,"participants":["Peter TB Brett","Gustav Hållberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"169926","messageId":"077cac32c74edaff2f20c84897bfc171@mail.theimps.com","threadId":"27613","inReplyTo":null,"subject":"[stgit PATCH] stgit.el: Stop \"Summary:\" being added to all commit msgs.","fromName":"Peter TB Brett","fromEmail":"peter@peter-b.co.uk","sentAt":"2011-06-13T08:37:26Z","receivedAt":"2011-06-13T08:37:26Z","isPatch":true,"sender":{"key":"peter@peter-b.co.uk","avatar":"https://gravatar.com/avatar/6b467f6653937dfb2de5b1cdd273b5f6c8f2dc7f4b9f75cb2ba27e62fae695fd?d=mp&s=160"},"body":"In Emacs 23.3.1, if `log-edit' is called with a non-nil `setup' argument,\nit unconditionally appends \"Summary:\" to the log buffer.  It causes great\nannoyance to have to remember to find and delete this string on every patch\ncommit message edit with stgit-mode.  This patch makes `stgit-edit' call\n`log-edit' with a nil `setup' argument.\n\nDid I mention that this is *incredibly annoying*?\n\nSee also https://gna.org/bugs/?18206\n\nPeter\n\n-- \nPeter Brett <peter@peter-b.co.uk>\nRemote Sensing Research Group\nSurrey Space Centre\n\n\nFrom 4cdf9770144933c5cd2b0399cc084841c1d5c46d Mon Sep 17 00:00:00 2001\nFrom: Peter TB Brett <peter@peter-b.co.uk>\nDate: Mon, 13 Jun 2011 09:33:12 +0100\nSubject: [PATCH] stgit.el: Stop \"Summary:\" being added to all commit msgs.\n\nIn Emacs 23.3.1, if `log-edit' is called with a non-nil `setup'\nargument, it unconditionally appends \"Summary:\" to the log buffer.  It\ncauses great annoyance to have to remember to find and delete this\nstring on every patch commit message edit with stgit-mode.  This patch\nmakes `stgit-edit' call `log-edit' with a nil `setup' argument.\n\nSigned-off-by: Peter TB Brett <peter@peter-b.co.uk>\n---\n contrib/stgit.el |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/stgit.el b/contrib/stgit.el\nindex c71df4b..f640e5e 100644\n--- a/contrib/stgit.el\n+++ b/contrib/stgit.el\n@@ -2298,7 +2298,7 @@ file ended up. You can then jump to the file with \\\n   (let ((patchsym (stgit-patch-name-at-point t t))\n         (edit-buf (get-buffer-create \"*StGit edit*\"))\n         (dir default-directory))\n-    (log-edit 'stgit-confirm-edit t nil edit-buf)\n+    (log-edit 'stgit-confirm-edit nil nil edit-buf)\n     (set (make-local-variable 'stgit-edit-patchsym) patchsym)\n     (setq default-directory dir)\n     (let ((standard-output edit-buf))\n-- \n1.7.6.rc1\n\n"},{"id":"169928","messageId":"BANLkTikDdf_eVZJKezRG4e=091GpV8TGjQ@mail.gmail.com","threadId":"27613","inReplyTo":"077cac32c74edaff2f20c84897bfc171@mail.theimps.com","subject":"Re: [stgit PATCH] stgit.el: Stop \"Summary:\" being added to all commit msgs.","fromName":"Gustav Hållberg","fromEmail":"gustav@gmail.com","sentAt":"2011-06-13T09:11:08Z","receivedAt":"2011-06-13T09:11:08Z","isPatch":true,"sender":{"key":"gustav@gmail.com","avatar":null},"body":"On Mon, Jun 13, 2011 at 10:37 AM, Peter TB Brett <peter@peter-b.co.uk> wrote:\n> Did I mention that this is *incredibly annoying*?\n\nI couldn't agree more, but if this is how all now-poor Emacs users\nwill expect log-edit to behave, maybe we ought to follow suit with\nrespect to adding christmas-tree-lit standard headers and such.\nFor sure, your patch improves the current situation which is broken,\nbut it's quite different from how git-status does it for example…\n\n- Gustav\n"},{"id":"169929","messageId":"acf4d471f1a1b1820b91bbdb7c7a1c76@mail.theimps.com","threadId":"27613","inReplyTo":"BANLkTikDdf_eVZJKezRG4e=091GpV8TGjQ@mail.gmail.com","subject":"Re: [stgit PATCH] stgit.el: Stop \"Summary:\" being added to all commit msgs.","fromName":"Peter TB Brett","fromEmail":"peter@peter-b.co.uk","sentAt":"2011-06-13T09:44:49Z","receivedAt":"2011-06-13T09:44:49Z","isPatch":true,"sender":{"key":"peter@peter-b.co.uk","avatar":"https://gravatar.com/avatar/6b467f6653937dfb2de5b1cdd273b5f6c8f2dc7f4b9f75cb2ba27e62fae695fd?d=mp&s=160"},"body":"On Mon, 13 Jun 2011 11:11:08 +0200, Gustav Hållberg <gustav@gmail.com>\nwrote:\n> On Mon, Jun 13, 2011 at 10:37 AM, Peter TB Brett <peter@peter-b.co.uk>\n> wrote:\n>> Did I mention that this is *incredibly annoying*?\n> \n> I couldn't agree more, but if this is how all now-poor Emacs users\n> will expect log-edit to behave, maybe we ought to follow suit with\n> respect to adding christmas-tree-lit standard headers and such.\n> For sure, your patch improves the current situation which is broken,\n> but it's quite different from how git-status does it for example…\n\nOkay. The patch has another bug in that it causes the *previous* message\nedited to get appended instead (WTF?) so please disregard this for now.\n\nIs it possible to borrow the code from git.el?\n\nPeter\n\n-- \nPeter Brett <peter@peter-b.co.uk>\nRemote Sensing Research Group\nSurrey Space Centre\n"}]}