threads / patch / 26731

patchDocumentation: running test with --debug keeps "trash" directory

Subject: [PATCH] Documentation: running test with --debug keeps "trash" directory

## tl;dr

3 messages between Mar 14, 2011 and Mar 15, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Piotr Krukowiecki· Mar 14, 2011, 19:50 UTC · lore
Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
---
 t/README |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

It wasn't documented and I didn't notice it at first and found it out only after I've started implementing --keep-trash option.

Show changes to t/README +3 −0
diff --git a/t/README b/t/README
index 78c9e65..5db567e 100644
--- a/t/README
+++ b/t/README
@@ -79,6 +79,9 @@ appropriately before running "make".
 --debug::
 	This may help the person who is developing a new test.
 	It causes the command defined with test_debug to run.
+	The "trash" directory (used to store all temporary data
+	during testing) is not deleted even if there are no
+	failed tests.
 
 --immediate::
 	This causes the test to immediately exit upon the first
-- 
1.7.4.1.228.g9e388

-- 
Piotr Krukowiecki
Junio C Hamano· Mar 14, 2011, 21:32 UTC · re: Piotr Krukowiecki · lore

Re: [PATCH] Documentation: running test with --debug keeps "trash" directory

Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
Show 19 quoted lines
> Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
> ---
>  t/README |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> It wasn't documented and I didn't notice it at first and found
> it out only after I've started implementing --keep-trash option.
>
> diff --git a/t/README b/t/README
> index 78c9e65..5db567e 100644
> --- a/t/README
> +++ b/t/README
> @@ -79,6 +79,9 @@ appropriately before running "make".
>  --debug::
>  	This may help the person who is developing a new test.
>  	It causes the command defined with test_debug to run.
> +	The "trash" directory (used to store all temporary data
> +	during testing) is not deleted even if there are no
> +	failed tests.

missing is "...so that you can inspect its contents after the test finished." at the end.

>  --immediate::
>  	This causes the test to immediately exit upon the first
> -- 
> 1.7.4.1.228.g9e388
Piotr Krukowiecki· Mar 15, 2011, 19:58 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation: running test with --debug keeps "trash" directory

W dniu 14.03.2011 22:32, Junio C Hamano pisze:
Show 24 quoted lines
> Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
> 
>> Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
>> ---
>>  t/README |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> It wasn't documented and I didn't notice it at first and found
>> it out only after I've started implementing --keep-trash option.
>>
>> diff --git a/t/README b/t/README
>> index 78c9e65..5db567e 100644
>> --- a/t/README
>> +++ b/t/README
>> @@ -79,6 +79,9 @@ appropriately before running "make".
>>  --debug::
>>  	This may help the person who is developing a new test.
>>  	It causes the command defined with test_debug to run.
>> +	The "trash" directory (used to store all temporary data
>> +	during testing) is not deleted even if there are no
>> +	failed tests.
> 
> missing is "...so that you can inspect its contents after the test
> finished." at the end.

If you think it's needed here's a patch. I'm not sure - maybe it should be "after the test finishe_s_"? I'm not native English speaker though...

---8<---
From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Mon, 14 Mar 2011 18:50:47 +0100
Subject: [PATCH] Documentation: running test with --debug keeps "trash" directory
Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
---
 t/README |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Show changes to t/README +4 −0
diff --git a/t/README b/t/README
index 78c9e65..165e7cf 100644
--- a/t/README
+++ b/t/README
@@ -79,6 +79,10 @@ appropriately before running "make".
 --debug::
 	This may help the person who is developing a new test.
 	It causes the command defined with test_debug to run.
+	The "trash" directory (used to store all temporary data
+	during testing) is not deleted even if there are no
+	failed tests so that you can inspect its contents after
+	the test finished.
 
 --immediate::
 	This causes the test to immediately exit upon the first
-- 
1.7.4.1.228.g9e388


-- 
Piotr Krukowiecki

← back to recent threads