{"thread":{"id":"26731","subject":"[PATCH] Documentation: running test with --debug keeps \"trash\" directory","startedAt":"2011-03-14T19:50:18Z","lastAt":"2011-03-15T19:58:14Z","messageCount":3,"participants":["Piotr Krukowiecki","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"163339","messageId":"4D7E717A.8010605@gmail.com","threadId":"26731","inReplyTo":null,"subject":"[PATCH] Documentation: running test with --debug keeps \"trash\" directory","fromName":"Piotr Krukowiecki","fromEmail":"piotr.krukowiecki@gmail.com","sentAt":"2011-03-14T19:50:18Z","receivedAt":"2011-03-14T19:50:18Z","isPatch":true,"sender":{"key":"piotr.krukowiecki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3259959?v=4"},"body":"\n\nSigned-off-by: Piotr Krukowiecki \n---\n t/README | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\nIt wasn't documented and I didn't notice it at first and found\nit out only after I've started implementing --keep-trash option.\n\ndiff --git a/t/README b/t/README\nindex 78c9e65..5db567e 100644\n--- a/t/README\n+++ b/t/README\n@@ -79,6 +79,9 @@ appropriately before running \"make\".\n --debug::\n \tThis may help the person who is developing a new test.\n \tIt causes the command defined with test_debug to run.\n+\tThe \"trash\" directory (used to store all temporary data\n+\tduring testing) is not deleted even if there are no\n+\tfailed tests.\n \n --immediate::\n \tThis causes the test to immediately exit upon the first\n-- \n1.7.4.1.228.g9e388\n\n-- \nPiotr Krukowiecki\n"},{"id":"163346","messageId":"7vy64hbd6c.fsf@alter.siamese.dyndns.org","threadId":"26731","inReplyTo":"4D7E717A.8010605@gmail.com","subject":"Re: [PATCH] Documentation: running test with --debug keeps \"trash\" directory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-14T21:32:59Z","receivedAt":"2011-03-14T21:32:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Piotr Krukowiecki writes:\n\n> Signed-off-by: Piotr Krukowiecki \n> ---\n> t/README | 3 +++\n> 1 files changed, 3 insertions(+), 0 deletions(-)\n>\n> It wasn't documented and I didn't notice it at first and found\n> it out only after I've started implementing --keep-trash option.\n>\n> diff --git a/t/README b/t/README\n> index 78c9e65..5db567e 100644\n> --- a/t/README\n> +++ b/t/README\n> @@ -79,6 +79,9 @@ appropriately before running \"make\".\n> --debug::\n> \tThis may help the person who is developing a new test.\n> \tIt causes the command defined with test_debug to run.\n> +\tThe \"trash\" directory (used to store all temporary data\n> +\tduring testing) is not deleted even if there are no\n> +\tfailed tests.\n\nmissing is \"...so that you can inspect its contents after the test\nfinished.\" at the end.\n\n> --immediate::\n> \tThis causes the test to immediately exit upon the first\n> -- \n> 1.7.4.1.228.g9e388\n"},{"id":"163407","messageId":"4D7FC4D6.9010100@gmail.com","threadId":"26731","inReplyTo":"7vy64hbd6c.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Documentation: running test with --debug keeps \"trash\" directory","fromName":"Piotr Krukowiecki","fromEmail":"piotr.krukowiecki@gmail.com","sentAt":"2011-03-15T19:58:14Z","receivedAt":"2011-03-15T19:58:14Z","isPatch":true,"sender":{"key":"piotr.krukowiecki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3259959?v=4"},"body":"W dniu 14.03.2011 22:32, Junio C Hamano pisze:\n> Piotr Krukowiecki writes:\n> \n>> Signed-off-by: Piotr Krukowiecki \n>> ---\n>> t/README | 3 +++\n>> 1 files changed, 3 insertions(+), 0 deletions(-)\n>>\n>> It wasn't documented and I didn't notice it at first and found\n>> it out only after I've started implementing --keep-trash option.\n>>\n>> diff --git a/t/README b/t/README\n>> index 78c9e65..5db567e 100644\n>> --- a/t/README\n>> +++ b/t/README\n>> @@ -79,6 +79,9 @@ appropriately before running \"make\".\n>> --debug::\n>> \tThis may help the person who is developing a new test.\n>> \tIt causes the command defined with test_debug to run.\n>> +\tThe \"trash\" directory (used to store all temporary data\n>> +\tduring testing) is not deleted even if there are no\n>> +\tfailed tests.\n> \n> missing is \"...so that you can inspect its contents after the test\n> finished.\" at the end.\n\nIf you think it's needed here's a patch. \nI'm not sure - maybe it should be \"after the test finishe_s_\"? I'm not\nnative English speaker though...\n\n---8<---\nFrom: Piotr Krukowiecki \nDate: Mon, 14 Mar 2011 18:50:47 +0100\nSubject: [PATCH] Documentation: running test with --debug keeps \"trash\" directory\n\n\nSigned-off-by: Piotr Krukowiecki \n---\n t/README | 4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/t/README b/t/README\nindex 78c9e65..165e7cf 100644\n--- a/t/README\n+++ b/t/README\n@@ -79,6 +79,10 @@ appropriately before running \"make\".\n --debug::\n \tThis may help the person who is developing a new test.\n \tIt causes the command defined with test_debug to run.\n+\tThe \"trash\" directory (used to store all temporary data\n+\tduring testing) is not deleted even if there are no\n+\tfailed tests so that you can inspect its contents after\n+\tthe test finished.\n \n --immediate::\n \tThis causes the test to immediately exit upon the first\n-- \n1.7.4.1.228.g9e388\n\n\n-- \nPiotr Krukowiecki\n"}]}