threads / discuss / 26281
Subject: core.whitespace space-in-indent feature request
Victor EngmarkHi all,
I couldn't find this mentioned anywhere, but it would be useful for languages where you typically want only tab characters in indentation, like makefiles. Would be equivalent or similar to indent-with-non-tab and tabwidth=1.
-- Victor Engmark
Drew NorthupRe: core.whitespace space-in-indent feature request
On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote:
> Hi all, > > I couldn't find this mentioned anywhere, but it would be useful for > languages where you typically want only tab characters in indentation, > like makefiles. Would be equivalent or similar to indent-with-non-tab > and tabwidth=1.
Victor, What would the point of this be? Git doesn't change the layout of the code when storing it--that's up to the thing between the chair and the keyboard.
-- -Drew Northup ________________________________________________ "As opposed to vegetable or mineral error?" -John Pescatore, SANS NewsBites Vol. 12 Num. 59
Junio C HamanoRe: core.whitespace space-in-indent feature request
Drew Northup <drew.northup@maine.edu> writes:
> On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >> Hi all, >> >> I couldn't find this mentioned anywhere, but it would be useful for >> languages where you typically want only tab characters in indentation, >> like makefiles. Would be equivalent or similar to indent-with-non-tab >> and tabwidth=1. > > Victor, > What would the point of this be? Git doesn't change the layout of the > code when storing it--that's up to the thing between the chair and the > keyboard.
True, but I think Victor wants to be able to ask "diff --check" to complain and diff --color to highlight when it sees a line that begins with a SP (or a HT then SP) by setting:
* whitespace=space-in-indent
or something in the attributes file.
As "equivalence" exists, not very much interested in coding it myself, though ;-)
Re: core.whitespace space-in-indent feature request
On Jan 18, 2011, at 9:31 PM, Junio C Hamano wrote:
> Drew Northup <drew.northup@maine.edu> writes: > >> On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >>> Hi all, >>> >>> I couldn't find this mentioned anywhere, but it would be useful for >>> languages where you typically want only tab characters in indentation, >>> like makefiles. Would be equivalent or similar to indent-with-non-tab >>> and tabwidth=1. >> >> Victor, >> What would the point of this be? Git doesn't change the layout of the >> code when storing it--that's up to the thing between the chair and the >> keyboard. > > True, but I think Victor wants to be able to ask "diff --check" to > complain and diff --color to highlight when it sees a line that begins > with a SP (or a HT then SP) by setting: > > * whitespace=space-in-indent > > or something in the attributes file. > > As "equivalence" exists, not very much interested in coding it myself, > though ;-)
That's it, but it turns out the settings don't work the way I expected:
$ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1'
$ touch whitespace.txt
$ git add whitespace.txt
[Add the following to the file]
HT
SP
SP HT
HT SP
2 SP
2 HT
8 SP
$ git diff --colorOnly the "SP HT" and "8 SP" indentations are colored; I expected "SP" and "2 SP" to also be colored, and I would expect space-in-indent to also trigger on "HT SP".
Cheers,
-- Victor
Johannes SixtRe: core.whitespace space-in-indent feature request
Am 1/19/2011 10:42, schrieb Victor Engmark:
> $ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1'
tabwidth= is not in any released version of git, yet.
> Only the "SP HT" and "8 SP" indentations are colored; ...
This is no surprise, unless you are using a version that has commit v1.7.4-rc0~52^2.
-- Hannes
Re: core.whitespace space-in-indent feature request
On Jan 19, 2011, at 10:42 AM, Victor Engmark wrote:
> On Jan 18, 2011, at 9:31 PM, Junio C Hamano wrote: > >> Drew Northup <drew.northup@maine.edu> writes: >> >>> On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >>>> Hi all, >>>> >>>> I couldn't find this mentioned anywhere, but it would be useful for >>>> languages where you typically want only tab characters in indentation, >>>> like makefiles. Would be equivalent or similar to indent-with-non-tab >>>> and tabwidth=1. >>> >>> Victor, >>> What would the point of this be? Git doesn't change the layout of the >>> code when storing it--that's up to the thing between the chair and the >>> keyboard. >> >> True, but I think Victor wants to be able to ask "diff --check" to >> complain and diff --color to highlight when it sees a line that begins >> with a SP (or a HT then SP) by setting: >> >> * whitespace=space-in-indent >> >> or something in the attributes file. >> >> As "equivalence" exists, not very much interested in coding it myself, >> though ;-) > > That's it, but it turns out the settings don't work the way I expected: > > $ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1' > $ touch whitespace.txt > $ git add whitespace.txt > [Add the following to the file] > HT > SP > SP HT > HT SP > 2 SP > 2 HT > 8 SP
Bloody OS X Mail - All those lines should of course be indented with the characters indicated at the end of the line.
Cheers,
-- Victor