# core.whitespace space-in-indent feature request 6 messages from 2011-01-14 to 2011-01-19. Participants: Victor Engmark, Drew Northup, Junio C Hamano, Johannes Sixt. Thread: https://gitlist.dev/t/26281 ## Victor Engmark, 2011-01-14 12:40 Subject: core.whitespace space-in-indent feature request Message-ID: URL: https://gitlist.dev/e/AANLkTikiHXofGVg9QECg9a4U4r4VGD1tb6oMV21nzd9W%40mail.gmail.com ``` Hi all, I couldn't find this mentioned anywhere, but it would be useful for languages where you typically want only tab characters in indentation, like makefiles. Would be equivalent or similar to indent-with-non-tab and tabwidth=1. -- Victor Engmark ``` ## Drew Northup, 2011-01-18 19:51 Subject: Re: core.whitespace space-in-indent feature request Message-ID: <1295380297.3778.47.camel@drew-northup.unet.maine.edu> URL: https://gitlist.dev/e/1295380297.3778.47.camel%40drew-northup.unet.maine.edu In-Reply-To: ``` On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: > Hi all, > > I couldn't find this mentioned anywhere, but it would be useful for > languages where you typically want only tab characters in indentation, > like makefiles. Would be equivalent or similar to indent-with-non-tab > and tabwidth=1. Victor, What would the point of this be? Git doesn't change the layout of the code when storing it--that's up to the thing between the chair and the keyboard. -- -Drew Northup ________________________________________________ "As opposed to vegetable or mineral error?" -John Pescatore, SANS NewsBites Vol. 12 Num. 59 ``` ## Junio C Hamano, 2011-01-18 20:31 Subject: Re: core.whitespace space-in-indent feature request Message-ID: <7vwrm2j6nv.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwrm2j6nv.fsf%40alter.siamese.dyndns.org In-Reply-To: <1295380297.3778.47.camel@drew-northup.unet.maine.edu> ``` Drew Northup writes: > On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >> Hi all, >> >> I couldn't find this mentioned anywhere, but it would be useful for >> languages where you typically want only tab characters in indentation, >> like makefiles. Would be equivalent or similar to indent-with-non-tab >> and tabwidth=1. > > Victor, > What would the point of this be? Git doesn't change the layout of the > code when storing it--that's up to the thing between the chair and the > keyboard. True, but I think Victor wants to be able to ask "diff --check" to complain and diff --color to highlight when it sees a line that begins with a SP (or a HT then SP) by setting: * whitespace=space-in-indent or something in the attributes file. As "equivalence" exists, not very much interested in coding it myself, though ;-) ``` ## Victor Engmark, 2011-01-19 09:42 Subject: Re: core.whitespace space-in-indent feature request Message-ID: <09F2551C-40E6-40DC-BE97-8DCFF3601C8C@terreactive.ch> URL: https://gitlist.dev/e/09F2551C-40E6-40DC-BE97-8DCFF3601C8C%40terreactive.ch In-Reply-To: <20205598.46894.1295382705010.JavaMail.trustmail@mail1.terreactive.ch> ``` On Jan 18, 2011, at 9:31 PM, Junio C Hamano wrote: > Drew Northup writes: > >> On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >>> Hi all, >>> >>> I couldn't find this mentioned anywhere, but it would be useful for >>> languages where you typically want only tab characters in indentation, >>> like makefiles. Would be equivalent or similar to indent-with-non-tab >>> and tabwidth=1. >> >> Victor, >> What would the point of this be? Git doesn't change the layout of the >> code when storing it--that's up to the thing between the chair and the >> keyboard. > > True, but I think Victor wants to be able to ask "diff --check" to > complain and diff --color to highlight when it sees a line that begins > with a SP (or a HT then SP) by setting: > > * whitespace=space-in-indent > > or something in the attributes file. > > As "equivalence" exists, not very much interested in coding it myself, > though ;-) That's it, but it turns out the settings don't work the way I expected: $ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1' $ touch whitespace.txt $ git add whitespace.txt [Add the following to the file] HT SP SP HT HT SP 2 SP 2 HT 8 SP $ git diff --color Only the "SP HT" and "8 SP" indentations are colored; I expected "SP" and "2 SP" to also be colored, and I would expect space-in-indent to also trigger on "HT SP". Cheers, -- Victor ``` ## Victor Engmark, 2011-01-19 10:53 Subject: Re: core.whitespace space-in-indent feature request Message-ID: <4A1964D5-609C-418B-BDEF-F5B52EC98F95@terreactive.ch> URL: https://gitlist.dev/e/4A1964D5-609C-418B-BDEF-F5B52EC98F95%40terreactive.ch In-Reply-To: <3798749.47565.1295432145824.JavaMail.trustmail@mail1.terreactive.ch> ``` On Jan 19, 2011, at 10:42 AM, Victor Engmark wrote: > On Jan 18, 2011, at 9:31 PM, Junio C Hamano wrote: > >> Drew Northup writes: >> >>> On Fri, 2011-01-14 at 13:40 +0100, Victor Engmark wrote: >>>> Hi all, >>>> >>>> I couldn't find this mentioned anywhere, but it would be useful for >>>> languages where you typically want only tab characters in indentation, >>>> like makefiles. Would be equivalent or similar to indent-with-non-tab >>>> and tabwidth=1. >>> >>> Victor, >>> What would the point of this be? Git doesn't change the layout of the >>> code when storing it--that's up to the thing between the chair and the >>> keyboard. >> >> True, but I think Victor wants to be able to ask "diff --check" to >> complain and diff --color to highlight when it sees a line that begins >> with a SP (or a HT then SP) by setting: >> >> * whitespace=space-in-indent >> >> or something in the attributes file. >> >> As "equivalence" exists, not very much interested in coding it myself, >> though ;-) > > That's it, but it turns out the settings don't work the way I expected: > > $ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1' > $ touch whitespace.txt > $ git add whitespace.txt > [Add the following to the file] > HT > SP > SP HT > HT SP > 2 SP > 2 HT > 8 SP Bloody OS X Mail - All those lines should of course be indented with the characters indicated at the end of the line. Cheers, -- Victor ``` ## Johannes Sixt, 2011-01-19 11:09 Subject: Re: core.whitespace space-in-indent feature request Message-ID: <4D36C681.7020400@viscovery.net> URL: https://gitlist.dev/e/4D36C681.7020400%40viscovery.net In-Reply-To: <09F2551C-40E6-40DC-BE97-8DCFF3601C8C@terreactive.ch> ``` Am 1/19/2011 10:42, schrieb Victor Engmark: > $ git config --add core.whitespace 'indent-with-non-tab,tabwidth=1' tabwidth= is not in any released version of git, yet. > Only the "SP HT" and "8 SP" indentations are colored; ... This is no surprise, unless you are using a version that has commit v1.7.4-rc0~52^2. -- Hannes ```