threads / patch / 26171

v2msvc: Fix compilation error due to missing mktemp() declaration

Subject: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration

## tl;dr

3 messages between Jan 1, 2011 and Jan 11, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· Jan 1, 2011, 20:31 UTC · lore

Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed the compat/vcbuild/include/dirent.h compatibility header file. This file, among other things, included the <io.h> system header file which provides the declaration of the mktemp() function.

In order to fix the compilation error, we add an include directive for <io.h> to the compat/mingw.h header.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Change from v1:
    - add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h

ATB, Ramsay Jones

 compat/mingw.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to compat/mingw.h +1 −0
diff --git a/compat/mingw.h b/compat/mingw.h
index cafc1eb..1c6bc02 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -1,5 +1,6 @@
 #include <winsock2.h>
 #include <ws2tcpip.h>
+#include <io.h>
 
 /*
  * things that are not available in header files
-- 
1.7.3
Ramsay Jones· Jan 11, 2011, 18:33 UTC · re: Ramsay Jones · lore

Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration

Ramsay Jones wrote:
Show 31 quoted lines
> Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed
> the compat/vcbuild/include/dirent.h compatibility header file.
> This file, among other things, included the <io.h> system header
> file which provides the declaration of the mktemp() function.
> 
> In order to fix the compilation error, we add an include directive
> for <io.h> to the compat/mingw.h header.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
> 
> Change from v1:
>     - add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h
> 
> ATB,
> Ramsay Jones
> 
>  compat/mingw.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/compat/mingw.h b/compat/mingw.h
> index cafc1eb..1c6bc02 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -1,5 +1,6 @@
>  #include <winsock2.h>
>  #include <ws2tcpip.h>
> +#include <io.h>
>  
>  /*
>   * things that are not available in header files

ping... Are there any remaining concerns regarding this patch? Just let me know.

ATB, Ramsay Jones

Junio C Hamano· Jan 11, 2011, 20:14 UTC · re: Ramsay Jones · lore

Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> ping... Are there any remaining concerns regarding this patch?
I dunno.  Is everybody on the Windows side happy with it?

← back to recent threads