{"thread":{"id":"26171","subject":"[PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration","startedAt":"2011-01-01T20:31:02Z","lastAt":"2011-01-11T20:14:51Z","messageCount":3,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"158801","messageId":"4D1F8F06.9090700@ramsay1.demon.co.uk","threadId":"26171","inReplyTo":null,"subject":"[PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-01-01T20:31:02Z","receivedAt":"2011-01-01T20:31:02Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed\nthe compat/vcbuild/include/dirent.h compatibility header file.\nThis file, among other things, included the <io.h> system header\nfile which provides the declaration of the mktemp() function.\n\nIn order to fix the compilation error, we add an include directive\nfor <io.h> to the compat/mingw.h header.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nChange from v1:\n    - add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h\n\nATB,\nRamsay Jones\n\n compat/mingw.h |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/compat/mingw.h b/compat/mingw.h\nindex cafc1eb..1c6bc02 100644\n--- a/compat/mingw.h\n+++ b/compat/mingw.h\n@@ -1,5 +1,6 @@\n #include <winsock2.h>\n #include <ws2tcpip.h>\n+#include <io.h>\n \n /*\n  * things that are not available in header files\n-- \n1.7.3\n"},{"id":"159359","messageId":"4D2CA28A.4070401@ramsay1.demon.co.uk","threadId":"26171","inReplyTo":"4D1F8F06.9090700@ramsay1.demon.co.uk","subject":"Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-01-11T18:33:46Z","receivedAt":"2011-01-11T18:33:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Ramsay Jones wrote:\n> Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed\n> the compat/vcbuild/include/dirent.h compatibility header file.\n> This file, among other things, included the <io.h> system header\n> file which provides the declaration of the mktemp() function.\n> \n> In order to fix the compilation error, we add an include directive\n> for <io.h> to the compat/mingw.h header.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n> \n> Change from v1:\n>     - add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h\n> \n> ATB,\n> Ramsay Jones\n> \n>  compat/mingw.h |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n> \n> diff --git a/compat/mingw.h b/compat/mingw.h\n> index cafc1eb..1c6bc02 100644\n> --- a/compat/mingw.h\n> +++ b/compat/mingw.h\n> @@ -1,5 +1,6 @@\n>  #include <winsock2.h>\n>  #include <ws2tcpip.h>\n> +#include <io.h>\n>  \n>  /*\n>   * things that are not available in header files\n\nping... Are there any remaining concerns regarding this patch?\nJust let me know.\n\nATB,\nRamsay Jones\n"},{"id":"159379","messageId":"7vaaj742pw.fsf@alter.siamese.dyndns.org","threadId":"26171","inReplyTo":"4D2CA28A.4070401@ramsay1.demon.co.uk","subject":"Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-11T20:14:51Z","receivedAt":"2011-01-11T20:14:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:\n\n> ping... Are there any remaining concerns regarding this patch?\n\nI dunno.  Is everybody on the Windows side happy with it?\n"}]}