Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal

Алексей Крезов· Dec 24, 2010, 12:46 UTC · lore

Hello!
I've found some bugs in Git:
1. git-svn:
  git svn set-tree/dcommit do not respect svn.pathnameencoding config variable
  although git svn fetch does
  here is the my patch - see attach git-svn.patch
2. git-completion
  when GIT_PS1_SHOWDIRTYSTATE is set diff.ignoreSubmodules config
  variable is not respected
  here is the my patch - see attach git-completion.bash.patch
3. CLASS procedures/functions are not detected (just
procedures/functions do) in hunk headers
for git diff for Pascal files
  here is the my patch - see attach userdiff.c.patch

P.S. All patches is against Git v1.7.3.4
  

mailto:zapped@mail.ru

diff --git a/userdiff.c b/userdiff.c
index f9e05b5..259a382 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -52,7 +52,7 @@ PATTERNS("objc",
 	 "|[-+*/<>%&^|=!]=|--|\\+\\+|<<=?|>>=?|&&|\\|\\||::|->"
 	 "|[^[:space:]]|[\x80-\xff]+"),
 PATTERNS("pascal",
-	 "^((procedure|function|constructor|destructor|interface|"
+	 "^(((class[ \t]+)?(procedure|function)|constructor|destructor|interface|"
 		"implementation|initialization|finalization)[ \t]*.*)$"
 	 "\n"
 	 "^(.*=[ \t]*(class|record).*)$",


diff --git a/git-svn.perl b/git-svn.perl
index 757de82..399bf4c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4451,6 +4451,7 @@ sub new {
 	$self->{path_prefix} = length $self->{svn_path} ?
 	                       "$self->{svn_path}/" : '';
 	$self->{config} = $opts->{config};
+	$self->{pathnameencoding} = Git::config('svn.pathnameencoding');
 	return $self;
 }
 


diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d3037fc..50fc385 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -280,7 +280,8 @@ __git_ps1 ()
 		elif [ "true" = "$(git rev-parse --is-inside-work-tree 2>/dev/null)" ]; then
 			if [ -n "${GIT_PS1_SHOWDIRTYSTATE-}" ]; then
 				if [ "$(git config --bool bash.showDirtyState)" != "false" ]; then
-					git diff --no-ext-diff --quiet --exit-code || w="*"
+					is=$(git config diff.ignoreSubmodules)
+					git diff --no-ext-diff --quiet --exit-code --ignore-submodules=$is || w="*"
 					if git rev-parse --quiet --verify HEAD >/dev/null; then
 						git diff-index --cached --quiet HEAD -- || i="+"
 					else

Matthieu Moy· Dec 24, 2010, 14:10 UTC · re: Алексей Крезов · lore

Re: Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal

Алексей Крезов <zapped@mail.ru> writes:

> Hello!

Hi,

> I've found some bugs in Git:

* Patches cannot be included without your signoff.

* Please send the patches inline, together with the commit message, so
  that review is easy, and that our maintener can easily apply it.
  Doing local commits, and using git send-email will make it easy.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Tay Ray Chuan· Dec 24, 2010, 14:25 UTC · re: Matthieu Moy · lore

Re: Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal

2010/12/24 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:

> Алексей Крезов <zapped@mail.ru> writes:
>
>> Hello!
>
> Hi,
>
>> I've found some bugs in Git:
>
> Thanks for your interest and your patches, but please read
> Documentation/SubmittingPatches in th git sources. In particular:

for your convenience:

  https://github.com/git/git/blob/master/Documentation/SubmittingPatches

-- 
Cheers,
Ray Chuan