{"thread":{"id":"26133","subject":"Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal","startedAt":"2010-12-24T12:46:26Z","lastAt":"2010-12-24T14:25:30Z","messageCount":3,"participants":["Алексей Крезов","Matthieu Moy","Tay Ray Chuan"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"158552","messageId":"6110634424.20101224154626@mail.ru","threadId":"26133","inReplyTo":null,"subject":"Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal","fromName":"Алексей Крезов","fromEmail":"zapped@mail.ru","sentAt":"2010-12-24T12:46:26Z","receivedAt":"2010-12-24T12:46:26Z","isPatch":false,"sender":{"key":"alex.crezoff@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1183752?v=4"},"body":"Hello!\nI've found some bugs in Git:\n1. git-svn:\n git svn set-tree/dcommit do not respect svn.pathnameencoding config variable\n although git svn fetch does\n here is the my patch - see attach git-svn.patch\n2. git-completion\n when GIT_PS1_SHOWDIRTYSTATE is set diff.ignoreSubmodules config\n variable is not respected\n here is the my patch - see attach git-completion.bash.patch\n3. CLASS procedures/functions are not detected (just\nprocedures/functions do) in hunk headers\nfor git diff for Pascal files\n here is the my patch - see attach userdiff.c.patch\n\nP.S. All patches is against Git v1.7.3.4\n \n\nmailto:zapped@mail.ru\n\ndiff --git a/userdiff.c b/userdiff.c\nindex f9e05b5..259a382 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -52,7 +52,7 @@ PATTERNS(\"objc\",\n \t \"|[-+*/<>%&^|=!]=|--|\\\\+\\\\+|<<=?|>>=?|&&|\\\\|\\\\||::|->\"\n \t \"|[^[:space:]]|[\\x80-\\xff]+\"),\n PATTERNS(\"pascal\",\n-\t \"^((procedure|function|constructor|destructor|interface|\"\n+\t \"^(((class[ \\t]+)?(procedure|function)|constructor|destructor|interface|\"\n \t\t\"implementation|initialization|finalization)[ \\t]*.*)$\"\n \t \"\\n\"\n \t \"^(.*=[ \\t]*(class|record).*)$\",\n\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 757de82..399bf4c 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -4451,6 +4451,7 @@ sub new {\n \t$self->{path_prefix} = length $self->{svn_path} ?\n \t \"$self->{svn_path}/\" : '';\n \t$self->{config} = $opts->{config};\n+\t$self->{pathnameencoding} = Git::config('svn.pathnameencoding');\n \treturn $self;\n }\n \n\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex d3037fc..50fc385 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -280,7 +280,8 @@ __git_ps1 ()\n \t\telif [ \"true\" = \"$(git rev-parse --is-inside-work-tree 2>/dev/null)\" ]; then\n \t\t\tif [ -n \"${GIT_PS1_SHOWDIRTYSTATE-}\" ]; then\n \t\t\t\tif [ \"$(git config --bool bash.showDirtyState)\" != \"false\" ]; then\n-\t\t\t\t\tgit diff --no-ext-diff --quiet --exit-code || w=\"*\"\n+\t\t\t\t\tis=$(git config diff.ignoreSubmodules)\n+\t\t\t\t\tgit diff --no-ext-diff --quiet --exit-code --ignore-submodules=$is || w=\"*\"\n \t\t\t\t\tif git rev-parse --quiet --verify HEAD >/dev/null; then\n \t\t\t\t\t\tgit diff-index --cached --quiet HEAD -- || i=\"+\"\n \t\t\t\t\telse\n"},{"id":"158559","messageId":"vpq1v575kiq.fsf@bauges.imag.fr","threadId":"26133","inReplyTo":"6110634424.20101224154626@mail.ru","subject":"Re: Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2010-12-24T14:10:37Z","receivedAt":"2010-12-24T14:10:37Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Алексей Крезов writes:\n\n> Hello!\n\nHi,\n\n> I've found some bugs in Git:\n\nThanks for your interest and your patches, but please read\nDocumentation/SubmittingPatches in th git sources. In particular:\n\n* Patches cannot be included without your signoff.\n\n* Please send the patches inline, together with the commit message, so\n that review is easy, and that our maintener can easily apply it.\n Doing local commits, and using git send-email will make it easy.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"158560","messageId":"AANLkTi=_V1PVy7TG_ZOJmBM3J9TosbDTnEzQqxf3jCgm@mail.gmail.com","threadId":"26133","inReplyTo":"vpq1v575kiq.fsf@bauges.imag.fr","subject":"Re: Bug reports & patches: git-svn, git-completion, git diff hunk headers for Pascal","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2010-12-24T14:25:30Z","receivedAt":"2010-12-24T14:25:30Z","isPatch":false,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"2010/12/24 Matthieu Moy :\n> Алексей Крезов writes:\n>\n>> Hello!\n>\n> Hi,\n>\n>> I've found some bugs in Git:\n>\n> Thanks for your interest and your patches, but please read\n> Documentation/SubmittingPatches in th git sources. In particular:\n\nfor your convenience:\n\n https://github.com/git/git/blob/master/Documentation/SubmittingPatches\n\n-- \nCheers,\nRay Chuan\n"}]}