[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings

Ramsay Jones· Dec 4, 2010, 19:01 UTC · lore

The msvc compiler thinks the 'failed_errno' variable could be used while uninitialised and issues 26 warnings thus:

    ...\git\run-command.c(142) : warning C4700: uninitialized local \
        variable 'failed_errno' used

In order to suppress the warnings, we simply initialise the variable to zero.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 run-command.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to run-command.c +1 −1

diff --git a/run-command.c b/run-command.c
index 2a1041e..0dad4da 100644
--- a/run-command.c
+++ b/run-command.c
@@ -139,7 +139,7 @@ int start_command(struct child_process *cmd)
 {
 	int need_in, need_out, need_err;
 	int fdin[2], fdout[2], fderr[2];
-	int failed_errno = failed_errno;
+	int failed_errno = 0;
 
 	/*
 	 * In case of errors we must keep the promise to close FDs

-- 
1.7.3

patch, 14 partsrun-command.c: Initialise variable to suppress msvc warnings