{"thread":{"id":"25960","subject":"[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings","startedAt":"2010-12-04T19:01:56Z","lastAt":"2010-12-04T19:01:56Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"157319","messageId":"4CFA9024.3030505@ramsay1.demon.co.uk","threadId":"25960","inReplyTo":null,"subject":"[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-12-04T19:01:56Z","receivedAt":"2010-12-04T19:01:56Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nThe msvc compiler thinks the 'failed_errno' variable could be used\nwhile uninitialised and issues 26 warnings thus:\n\n    ...\\git\\run-command.c(142) : warning C4700: uninitialized local \\\n        variable 'failed_errno' used\n\nIn order to suppress the warnings, we simply initialise the variable\nto zero.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n run-command.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex 2a1041e..0dad4da 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -139,7 +139,7 @@ int start_command(struct child_process *cmd)\n {\n \tint need_in, need_out, need_err;\n \tint fdin[2], fdout[2], fderr[2];\n-\tint failed_errno = failed_errno;\n+\tint failed_errno = 0;\n \n \t/*\n \t * In case of errors we must keep the promise to close FDs\n-- \n1.7.3\n"}]}