threads / patch / 25789

patchMatch lightweight tags too in bash prompt

Subject: [PATCH] Match lightweight tags too in bash prompt

## tl;dr

4 messages between Nov 19, 2010 and Dec 1, 2010. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

knittl· Nov 19, 2010, 15:43 UTC · lore
>From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
Date: Fri, 19 Nov 2010 16:40:02 +0100
Subject: [PATCH] Match lightweight tags too in bash prompt

provide `--tags` to git describe ---

bash prompt would display a commit's sha1, when checking out a lightweight tag. provide --tags to git describe in the completion script, so it will display the name of the tag (as it already does for annotated tags)

 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to contrib/completion/git-completion.bash +1 −1
diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index f710469..604fa79 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -261,7 +261,7 @@ __git_ps1 ()
 				(describe)
 					git describe HEAD ;;
 				(* | default)
-					git describe --exact-match HEAD ;;
+					git describe --tags --exact-match HEAD ;;
 				esac 2>/dev/null)" ||

 				b="$(cut -c1-7 "$g/HEAD" 2>/dev/null)..." ||

-- 
1.7.3.2.334.gd1031


-- 
typed with http://neo-layout.org
myFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!
Shawn Pearce· Nov 30, 2010, 18:04 UTC · re: knittl · lore

Re: [PATCH] Match lightweight tags too in bash prompt

On Fri, Nov 19, 2010 at 7:43 AM, knittl <knittl89@googlemail.com> wrote:
Show 6 quoted lines
> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
> From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
> Date: Fri, 19 Nov 2010 16:40:02 +0100
> Subject: [PATCH] Match lightweight tags too in bash prompt
>
> provide `--tags` to git describe
Missing signed-off-by-line.
Show 6 quoted lines
> ---
>
> bash prompt would display a commit's sha1, when checking out a lightweight tag.
> provide --tags to git describe in the completion script, so it will
> display the name
> of the tag (as it already does for annotated tags)

This information is useful justification for the change. It should therefore appear in the commit message, above the --- line.

-- 
Shawn.
knittl· Nov 30, 2010, 23:16 UTC · re: Shawn Pearce · lore

Re: [PATCH] Match lightweight tags too in bash prompt

On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce <spearce@spearce.org> wrote:
Show 9 quoted lines
> On Fri, Nov 19, 2010 at 7:43 AM, knittl <knittl89@googlemail.com> wrote:
>> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
>> From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
>> Date: Fri, 19 Nov 2010 16:40:02 +0100
>> Subject: [PATCH] Match lightweight tags too in bash prompt
>>
>> provide `--tags` to git describe
>
> Missing signed-off-by-line.
i mentioned the s-o-b line already in my forward-mail ;)
Show 9 quoted lines
>> ---
>>
>> bash prompt would display a commit's sha1, when checking out a lightweight tag.
>> provide --tags to git describe in the completion script, so it will
>> display the name
>> of the tag (as it already does for annotated tags)
>
> This information is useful justification for the change.  It should
> therefore appear in the commit message, above the --- line.
ok, i'll resend v2 tomorrow morning to you and the mailing list
cheers, daniel
-- 
typed with http://neo-layout.org
myFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!
Thiago Farina· Dec 1, 2010, 13:08 UTC · re: knittl · lore

Re: [PATCH] Match lightweight tags too in bash prompt

On Tue, Nov 30, 2010 at 9:16 PM, knittl <knittl89@googlemail.com> wrote:
Show 13 quoted lines
> On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce <spearce@spearce.org> wrote:
>> On Fri, Nov 19, 2010 at 7:43 AM, knittl <knittl89@googlemail.com> wrote:
>>> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
>>> From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
>>> Date: Fri, 19 Nov 2010 16:40:02 +0100
>>> Subject: [PATCH] Match lightweight tags too in bash prompt
>>>
>>> provide `--tags` to git describe
>>
>> Missing signed-off-by-line.
>
> i mentioned the s-o-b line already in my forward-mail ;)
>

I don't see it. You mean the From: line? If yes, that is not the convention used here.

You have to add a line:
Signed-off-by: Your Name <you@example.com>
Take a look at Documentation/SubmittingPatches

← back to recent threads