{"thread":{"id":"25789","subject":"[PATCH] Match lightweight tags too in bash prompt","startedAt":"2010-11-19T15:43:09Z","lastAt":"2010-12-01T13:08:06Z","messageCount":4,"participants":["knittl","Shawn Pearce","Thiago Farina"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"156183","messageId":"AANLkTikeH=MODho_GsZP5VPQmt2NOoHyfw2pbt4yqGkt@mail.gmail.com","threadId":"25789","inReplyTo":null,"subject":"[PATCH] Match lightweight tags too in bash prompt","fromName":"knittl","fromEmail":"knittl89@googlemail.com","sentAt":"2010-11-19T15:43:09Z","receivedAt":"2010-11-19T15:43:09Z","isPatch":true,"sender":{"key":"knittl89@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/2149217?v=4"},"body":">From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001\nFrom: Daniel Knittl-Frank \nDate: Fri, 19 Nov 2010 16:40:02 +0100\nSubject: [PATCH] Match lightweight tags too in bash prompt\n\nprovide `--tags` to git describe\n---\n\nbash prompt would display a commit's sha1, when checking out a lightweight tag.\nprovide --tags to git describe in the completion script, so it will\ndisplay the name\nof the tag (as it already does for annotated tags)\n\n contrib/completion/git-completion.bash | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex f710469..604fa79 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -261,7 +261,7 @@ __git_ps1 ()\n \t\t\t\t(describe)\n \t\t\t\t\tgit describe HEAD ;;\n \t\t\t\t(* | default)\n-\t\t\t\t\tgit describe --exact-match HEAD ;;\n+\t\t\t\t\tgit describe --tags --exact-match HEAD ;;\n \t\t\t\tesac 2>/dev/null)\" ||\n\n \t\t\t\tb=\"$(cut -c1-7 \"$g/HEAD\" 2>/dev/null)...\" ||\n-- \n1.7.3.2.334.gd1031\n\n\n-- \ntyped with http://neo-layout.org\nmyFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!\n"},{"id":"156897","messageId":"AANLkTi=0+s164XkWHho1++hvnTCAFg5=GGfMbHF4ugTE@mail.gmail.com","threadId":"25789","inReplyTo":"AANLkTikeH=MODho_GsZP5VPQmt2NOoHyfw2pbt4yqGkt@mail.gmail.com","subject":"Re: [PATCH] Match lightweight tags too in bash prompt","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2010-11-30T18:04:51Z","receivedAt":"2010-11-30T18:04:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"On Fri, Nov 19, 2010 at 7:43 AM, knittl wrote:\n> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001\n> From: Daniel Knittl-Frank \n> Date: Fri, 19 Nov 2010 16:40:02 +0100\n> Subject: [PATCH] Match lightweight tags too in bash prompt\n>\n> provide `--tags` to git describe\n\nMissing signed-off-by-line.\n\n> ---\n>\n> bash prompt would display a commit's sha1, when checking out a lightweight tag.\n> provide --tags to git describe in the completion script, so it will\n> display the name\n> of the tag (as it already does for annotated tags)\n\nThis information is useful justification for the change. It should\ntherefore appear in the commit message, above the --- line.\n\n-- \nShawn.\n"},{"id":"156903","messageId":"AANLkTinoZbSqwtiRwZ5+FZyn=6y7usgFi6p-JVUUTM5g@mail.gmail.com","threadId":"25789","inReplyTo":"AANLkTi=0+s164XkWHho1++hvnTCAFg5=GGfMbHF4ugTE@mail.gmail.com","subject":"Re: [PATCH] Match lightweight tags too in bash prompt","fromName":"knittl","fromEmail":"knittl89@googlemail.com","sentAt":"2010-11-30T23:16:38Z","receivedAt":"2010-11-30T23:16:38Z","isPatch":true,"sender":{"key":"knittl89@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/2149217?v=4"},"body":"On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce wrote:\n> On Fri, Nov 19, 2010 at 7:43 AM, knittl wrote:\n>> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001\n>> From: Daniel Knittl-Frank \n>> Date: Fri, 19 Nov 2010 16:40:02 +0100\n>> Subject: [PATCH] Match lightweight tags too in bash prompt\n>>\n>> provide `--tags` to git describe\n>\n> Missing signed-off-by-line.\n\ni mentioned the s-o-b line already in my forward-mail ;)\n\n>> ---\n>>\n>> bash prompt would display a commit's sha1, when checking out a lightweight tag.\n>> provide --tags to git describe in the completion script, so it will\n>> display the name\n>> of the tag (as it already does for annotated tags)\n>\n> This information is useful justification for the change.  It should\n> therefore appear in the commit message, above the --- line.\n\nok, i'll resend v2 tomorrow morning to you and the mailing list\n\n\ncheers, daniel\n\n-- \ntyped with http://neo-layout.org\nmyFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!\n"},{"id":"156920","messageId":"AANLkTik3GS6By4=k2oV77jUkyF5570qc56jgWGG9+gZr@mail.gmail.com","threadId":"25789","inReplyTo":"AANLkTinoZbSqwtiRwZ5+FZyn=6y7usgFi6p-JVUUTM5g@mail.gmail.com","subject":"Re: [PATCH] Match lightweight tags too in bash prompt","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-12-01T13:08:06Z","receivedAt":"2010-12-01T13:08:06Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Tue, Nov 30, 2010 at 9:16 PM, knittl wrote:\n> On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce wrote:\n>> On Fri, Nov 19, 2010 at 7:43 AM, knittl wrote:\n>>> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001\n>>> From: Daniel Knittl-Frank \n>>> Date: Fri, 19 Nov 2010 16:40:02 +0100\n>>> Subject: [PATCH] Match lightweight tags too in bash prompt\n>>>\n>>> provide `--tags` to git describe\n>>\n>> Missing signed-off-by-line.\n>\n> i mentioned the s-o-b line already in my forward-mail ;)\n>\n\nI don't see it. You mean the From: line? If yes, that is not the\nconvention used here.\n\nYou have to add a line:\nSigned-off-by: Your Name \n\nTake a look at Documentation/SubmittingPatches\n"}]}