threads / patch / 25741

patchgitk: Prevent the text pane from becoming editable

Subject: [PATCH] gitk: Prevent the text pane from becoming editable

## tl;dr

2 messages between Nov 14, 2010 and Dec 12, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Stefan Haller· Nov 14, 2010, 12:21 UTC · lore
From: Stefan Haller <stefan@haller-berlin.de>

When setting the "Patch/Tree" radio buttons to "Tree" and clicking on a file to display it, the text pane would accidentally become editable (because of the early return in getblobline).

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to gitk +1 −0
diff --git a/gitk b/gitk
index 45e3380..260be1b 100755
--- a/gitk
+++ b/gitk
@@ -7303,6 +7303,7 @@ proc getblobline {bf id} {
 			    [lindex [split $commentend .] 0]}]
 	    mark_ctext_line $lnum
 	}
+	$ctext config -state disabled
 	return 0
     }
     $ctext config -state disabled
-- 
1.7.3.2.154.gcfae0
Paul Mackerras· Dec 12, 2010, 04:24 UTC · re: Stefan Haller · lore

Re: [PATCH] gitk: Prevent the text pane from becoming editable

On Sun, Nov 14, 2010 at 01:21:50PM +0100, Stefan Haller wrote:
Show 6 quoted lines
> From: Stefan Haller <stefan@haller-berlin.de>
> 
> When setting the "Patch/Tree" radio buttons to "Tree" and
> clicking on a file to display it, the text pane would
> accidentally become editable (because of the early return
> in getblobline).
Thanks, applied.
Paul.

← back to recent threads