{"thread":{"id":"25741","subject":"[PATCH] gitk: Prevent the text pane from becoming editable","startedAt":"2010-11-14T12:21:50Z","lastAt":"2010-12-12T04:24:36Z","messageCount":2,"participants":["Stefan Haller","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"155842","messageId":"1289737310-33265-1-git-send-email-lists@haller-berlin.de","threadId":"25741","inReplyTo":null,"subject":"[PATCH] gitk: Prevent the text pane from becoming editable","fromName":"Stefan Haller","fromEmail":"lists@haller-berlin.de","sentAt":"2010-11-14T12:21:50Z","receivedAt":"2010-11-14T12:21:50Z","isPatch":true,"sender":{"key":"lists@haller-berlin.de","avatar":null},"body":"From: Stefan Haller <stefan@haller-berlin.de>\n\nWhen setting the \"Patch/Tree\" radio buttons to \"Tree\" and\nclicking on a file to display it, the text pane would\naccidentally become editable (because of the early return\nin getblobline).\n\nSigned-off-by: Stefan Haller <stefan@haller-berlin.de>\n---\n gitk |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 45e3380..260be1b 100755\n--- a/gitk\n+++ b/gitk\n@@ -7303,6 +7303,7 @@ proc getblobline {bf id} {\n \t\t\t    [lindex [split $commentend .] 0]}]\n \t    mark_ctext_line $lnum\n \t}\n+\t$ctext config -state disabled\n \treturn 0\n     }\n     $ctext config -state disabled\n-- \n1.7.3.2.154.gcfae0\n"},{"id":"157875","messageId":"20101212042436.GF3788@brick.ozlabs.ibm.com","threadId":"25741","inReplyTo":"1289737310-33265-1-git-send-email-lists@haller-berlin.de","subject":"Re: [PATCH] gitk: Prevent the text pane from becoming editable","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2010-12-12T04:24:36Z","receivedAt":"2010-12-12T04:24:36Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Sun, Nov 14, 2010 at 01:21:50PM +0100, Stefan Haller wrote:\n> From: Stefan Haller <stefan@haller-berlin.de>\n> \n> When setting the \"Patch/Tree\" radio buttons to \"Tree\" and\n> clicking on a file to display it, the text pane would\n> accidentally become editable (because of the early return\n> in getblobline).\n\nThanks, applied.\n\nPaul.\n"}]}