threads / patch / 2560

patchgit-commit: Having $GIT_COMMITTER_NAME implies -s

Subject: [PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s

## tl;dr

3 messages between Nov 16, 2005 and Nov 17, 2005. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Andreas Ericsson· Nov 16, 2005, 23:38 UTC · lore

I've been trying, in vain, to tell my colleagues to use the -s flag. With this patch I can at least fix up their .profile's myself.

Signed-off-by: Andreas Ericsson <ae@op5.se>

---

 git-commit.sh |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

applies-to: a2fe76123d6f5b835d3312a70a02ed4d07e25f8e d32c78570e25a9718721937b1ee9051e950ad1fd

Show changes to git-commit.sh +2 −4

diff --git a/git-commit.sh b/git-commit.sh
index 41955e8..ff9502c 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -134,8 +134,7 @@ then
 	cat "$GIT_DIR/MERGE_MSG"
 fi | git-stripspace >"$GIT_DIR"/COMMIT_EDITMSG
 
-case "$signoff" in
-t)
+if [ "$signoff" = t -o "$GIT_COMMITTER_NAME" ]; then
 	{
 		echo
 		git-var GIT_COMMITTER_IDENT | sed -e '
@@ -143,8 +142,7 @@ t)
 			s/^/Signed-off-by: /
 		'
 	} >>"$GIT_DIR"/COMMIT_EDITMSG
-	;;
-esac
+fi
 
 if [ -f "$GIT_DIR/MERGE_HEAD" ]; then
 	echo "#"
---
0.99.9.GIT

Junio C Hamano· Nov 17, 2005, 04:28 UTC · re: Andreas Ericsson · lore

Re: [PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s

I am not so sure about this. A Signed-off-by line used in the kernel and git projects has a specific meaning; you've read SubmittingPatches in either projects, have'nt you?

I do work on a machine from which I make commits to both git project and my day-job work project. I do not necessarily want to add Signed-off-by line in commits I make for the latter.

H. Peter Anvin· Nov 17, 2005, 05:27 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s

Junio C Hamano wrote:

Show 8 quoted lines

> I am not so sure about this.  A Signed-off-by line used in the
> kernel and git projects has a specific meaning; you've read
> SubmittingPatches in either projects, have'nt you?
> 
> I do work on a machine from which I make commits to both git
> project and my day-job work project.  I do not necessarily want
> to add Signed-off-by line in commits I make for the latter.
>

More importantly, it's vital that a Signed-off-by: line is always added with explicit awareness of the signer.

	-hpa