{"thread":{"id":"2560","subject":"[PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s","startedAt":"2005-11-16T23:38:29Z","lastAt":"2005-11-17T05:27:54Z","messageCount":3,"participants":["Andreas Ericsson","Junio C Hamano","H. Peter Anvin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"12062","messageId":"20051116233829.0B3C55BA81@nox.op5.se","threadId":"2560","inReplyTo":null,"subject":"[PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s","fromName":"Andreas Ericsson","fromEmail":"exon@op5.se","sentAt":"2005-11-16T23:38:29Z","receivedAt":"2005-11-16T23:38:29Z","isPatch":true,"sender":{"key":"exon@op5.se","avatar":"https://gravatar.com/avatar/b948c4f759e868f8e721e545e37afe2cf89cfa8e2ee8b70a432f0d76aee39891?d=mp&s=160"},"body":"\nI've been trying, in vain, to tell my colleagues to use the -s flag.\nWith this patch I can at least fix up their .profile's myself.\n\nSigned-off-by: Andreas Ericsson <ae@op5.se>\n\n---\n\n git-commit.sh |    6 ++----\n 1 files changed, 2 insertions(+), 4 deletions(-)\n\napplies-to: a2fe76123d6f5b835d3312a70a02ed4d07e25f8e\nd32c78570e25a9718721937b1ee9051e950ad1fd\ndiff --git a/git-commit.sh b/git-commit.sh\nindex 41955e8..ff9502c 100755\n--- a/git-commit.sh\n+++ b/git-commit.sh\n@@ -134,8 +134,7 @@ then\n \tcat \"$GIT_DIR/MERGE_MSG\"\n fi | git-stripspace >\"$GIT_DIR\"/COMMIT_EDITMSG\n \n-case \"$signoff\" in\n-t)\n+if [ \"$signoff\" = t -o \"$GIT_COMMITTER_NAME\" ]; then\n \t{\n \t\techo\n \t\tgit-var GIT_COMMITTER_IDENT | sed -e '\n@@ -143,8 +142,7 @@ t)\n \t\t\ts/^/Signed-off-by: /\n \t\t'\n \t} >>\"$GIT_DIR\"/COMMIT_EDITMSG\n-\t;;\n-esac\n+fi\n \n if [ -f \"$GIT_DIR/MERGE_HEAD\" ]; then\n \techo \"#\"\n---\n0.99.9.GIT\n"},{"id":"12075","messageId":"7vbr0j3nku.fsf@assigned-by-dhcp.cox.net","threadId":"2560","inReplyTo":"20051116233829.0B3C55BA81@nox.op5.se","subject":"Re: [PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-17T04:28:17Z","receivedAt":"2005-11-17T04:28:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I am not so sure about this.  A Signed-off-by line used in the\nkernel and git projects has a specific meaning; you've read\nSubmittingPatches in either projects, have'nt you?\n\nI do work on a machine from which I make commits to both git\nproject and my day-job work project.  I do not necessarily want\nto add Signed-off-by line in commits I make for the latter.\n"},{"id":"12076","messageId":"437C14DA.8000905@zytor.com","threadId":"2560","inReplyTo":"7vbr0j3nku.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] git-commit: Having $GIT_COMMITTER_NAME implies -s","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-11-17T05:27:54Z","receivedAt":"2005-11-17T05:27:54Z","isPatch":true,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Junio C Hamano wrote:\n> I am not so sure about this.  A Signed-off-by line used in the\n> kernel and git projects has a specific meaning; you've read\n> SubmittingPatches in either projects, have'nt you?\n> \n> I do work on a machine from which I make commits to both git\n> project and my day-job work project.  I do not necessarily want\n> to add Signed-off-by line in commits I make for the latter.\n> \n\nMore importantly, it's vital that a Signed-off-by: line is always added \nwith explicit awareness of the signer.\n\n\t-hpa\n"}]}