Test failures in today's pu: 0025, 4046, 4203, 9300, 9301

Hi *

My automatic test bisecter had several failures in today's pu. Hopefully I picked the right Cc list:

* t0025-crlf-auto still randomly fails, see

    http://mid.gmane.org/201007292340.01836.trast@student.ethz.ch

  Input always welcome on this one.  (That's not why I'm writing, but
  it was a convenient chance to point it out again...)

* t4046-diff-rename-factorize failed and bisected to 22214a1b (Add
  testcases for the --detect-bulk-moves diffcore flag.).

* t4203-mailmap: bisected to d8d2eb7d (mailmap: fix use of freed
  memory).  I saw some list traffic possibly related to this, is it
  fixed already?

* t9300-fast-import: bisected to a544a23c (t9300 (fast-import):
  another test for the "replace root" feature).  The relevant snippet
  is

    ./test-lib.sh: eval: line 413: syntax error near unexpected token `)'
    ./test-lib.sh: eval: line 413: `         treeÿgit rev-parse --verify N10:) &&'
    not ok - 62 N: modify subtree, extract it, and modify again

  I'm not sure whether the funny character after 'tree' made it
  through the (automated) email alright, but if it did, it is the
  glyph of the Latin1 rendition of 0xff.

* t9301-fast-import-notes: bisected to 5edde51 (fast-import:
  filemodify after M 040000 <tree> "" crashes).  The failure shows

    --- expect      2010-10-20 06:47:16.000000000 +0000
    +++ actual      2010-10-20 06:47:28.000000000 +0000
    @@ -1,800 +1,400 @@
         commit #400
    -    note for commit #400
         commit #399
    -    note for commit #399
         commit #398
    -    note for commit #398
         commit #397
    -    note for commit #397
         commit #396
    -    note for commit #396
         commit #395

  etc.

Recall that this is a RHEL5.5 box that runs a little helper script on a cronjob, which builds git and then runs the tests under valgrind. For each failing test, it then bisects the failure (again with valgrind).

Feel free to ask if you need more information.

Thomas Rast <trast@student.ethz.ch> writes:

I found one issue that will trigger if you do not run this test with its standard input corrected to a terminal and pushed out a fix last night. Did you have 3e3e1ef (t4203: do not let "git shortlog" DWIM based on tty, 2010-10-19) when your automated test ran?

Jonathan noticed breakage caused while I was applying his patch; should be corrected as of last night with 971728c (t9300 (fast-import): another test for the "replace root" feature, 2010-10-17).

I saw this one too; it seems to happen with jn/fast-import-fix topic.

Junio C Hamano wrote:

No.  False alarm then?

Same here. I thought I saw a valgrind failure, but it was only caused by -O0 apparently. In any case I cannot reproduce the test failur with current pu (b19f0de).

Failures as of yesterday (it alternates between next and pu, so today was next which was clean):

* 4046 has this valgrind failure:

  ==24237== Source and destination overlap in mempcpy(0x7feffed50, 0x7feffed50, 2)
  ==24237==    at 0x4C228DB: mempcpy (mc_replace_strmem.c:802)
  ==24237==    by 0x511AD6: copy_dirname (diffcore-rename.c:573)
  ==24237==    by 0x512071: check_one_bulk_move (diffcore-rename.c:744)
  ==24237==    by 0x5120C0: diffcore_bulk_moves (diffcore-rename.c:756)
  ==24237==    by 0x512988: diffcore_rename (diffcore-rename.c:961)
  ==24237==    by 0x4A48EF: diffcore_std (diff.c:4252)
  ==24237==    by 0x4974B5: run_diff_index (diff-lib.c:475)
  ==24237==    by 0x4267CD: cmd_diff_index (diff-index.c:50)
  ==24237==    by 0x404963: run_builtin (git.c:276)
  ==24237==    by 0x404AEE: handle_internal_command (git.c:435)
  ==24237==    by 0x404BD9: run_argv (git.c:479)
  ==24237==    by 0x404D3A: main (git.c:554)
  ==24237== 
  [snip suppression template]
  not ok - 14 diff-index --detect-bulk-moves on a move including a subdir.

* 950[012]: these are very strange.

Running them interactively appears to work ok, so maybe it is some environment bug. They appear to be "can't happen" style failures though, since they all look like (this one is from 9502)

  Initialized empty Git repository in /local/home/trast/git/t/trash directory.t9502-gitweb-standalone-parse-output/.git/
  expecting success: 
          test_commit first foo &&
          git branch xx/test &&
          FULL_ID=$(git rev-parse --verify HEAD) &&
          SHORT_ID=$(git rev-parse --verify --short=7 HEAD)

  fatal: This operation must be run in a work tree
  not ok - 1 setup

They are the only ones failing with this problem, though. They all bisect to

  commit e60cb38c7c4e0bdb8f9542f9925ba5cafd4cd33b
  Author: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
  Date:   Fri Oct 29 13:48:50 2010 +0700

      Remove all logic from get_git_work_tree()
      
      This helps break things some more. Eventually all repo setup logic
      should be centralized in setup_* functions. This helps push all the
      bugs back to setup_* functions.
      
      Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
      Signed-off-by: Junio C Hamano <gitster@pobox.com>

(Sorry, the UTF was garbled in cron-email transit...)

On Thu, Nov 04, 2010 at 10:37:01PM +0100, Thomas Rast wrote:

This is the issue raised by Jonathan. I have a fix for it although I did not publish it since I'm working on a refactoring. Posting it now.

2010/11/5 Thomas Rast <trast@student.ethz.ch>:

Can you rerun it with GIT_TRACE="$TRASH_DIRECTORY/trace" set on the failed tests?

This test is OK for me, although the next ones fail (pu db22585). How do I debug gitweb.perl? t9502.2 shows

FULL_ID  = 1005c80cc11c531d327b12195027cbbb4ff9e3cb
SHORT_ID = 1005c80
expecting success:
        gitweb_run "p=.git;a=snapshot;h=$FULL_ID;sf=tar" &&
        check_snapshot ".git-$SHORT_ID"

basename=.git-1005c80 tar: This does not look like a tar archive tar: Exiting with failure status due to previous errors not ok - 2 snapshot: full sha1

Not very helpful.

On t9500.1, I get

[Fri Nov 5 02:09:15 2010] gitweb.perl: Undefined subroutine &main::cache_fetch called at /home/pclouds/w/git/t/../gitweb/gitweb.perl line 1124.

Setting PERLLIB makes it work, but shouldn't the test script have done that already?

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

See http://article.gmane.org/gmane.comp.version-control.git/160395

Fixed in http://thread.gmane.org/gmane.comp.version-control.git/160147/focus=160476 (minimal fixup), not yet in 'pu'.