{"thread":{"id":"25487","subject":"Test failures in today's pu: 0025, 4046, 4203, 9300, 9301","startedAt":"2010-10-20T09:48:51Z","lastAt":"2010-11-05T11:28:01Z","messageCount":7,"participants":["Thomas Rast","Junio C Hamano","Yann Dirson","Nguyen Thai Ngoc Duy","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"153861","messageId":"201010201148.51551.trast@student.ethz.ch","threadId":"25487","inReplyTo":null,"subject":"Test failures in today's pu: 0025, 4046, 4203, 9300, 9301","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-10-20T09:48:51Z","receivedAt":"2010-10-20T09:48:51Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Hi *\n\nMy automatic test bisecter had several failures in today's pu.\nHopefully I picked the right Cc list:\n\n* t0025-crlf-auto still randomly fails, see\n\n    http://mid.gmane.org/201007292340.01836.trast@student.ethz.ch\n\n  Input always welcome on this one.  (That's not why I'm writing, but\n  it was a convenient chance to point it out again...)\n\n* t4046-diff-rename-factorize failed and bisected to 22214a1b (Add\n  testcases for the --detect-bulk-moves diffcore flag.).\n\n* t4203-mailmap: bisected to d8d2eb7d (mailmap: fix use of freed\n  memory).  I saw some list traffic possibly related to this, is it\n  fixed already?\n\n* t9300-fast-import: bisected to a544a23c (t9300 (fast-import):\n  another test for the \"replace root\" feature).  The relevant snippet\n  is\n\n    ./test-lib.sh: eval: line 413: syntax error near unexpected token `)'\n    ./test-lib.sh: eval: line 413: `         treeÿgit rev-parse --verify N10:) &&'\n    not ok - 62 N: modify subtree, extract it, and modify again\n\n  I'm not sure whether the funny character after 'tree' made it\n  through the (automated) email alright, but if it did, it is the\n  glyph of the Latin1 rendition of 0xff.\n\n* t9301-fast-import-notes: bisected to 5edde51 (fast-import:\n  filemodify after M 040000 <tree> \"\" crashes).  The failure shows\n\n    --- expect      2010-10-20 06:47:16.000000000 +0000\n    +++ actual      2010-10-20 06:47:28.000000000 +0000\n    @@ -1,800 +1,400 @@\n         commit #400\n    -    note for commit #400\n         commit #399\n    -    note for commit #399\n         commit #398\n    -    note for commit #398\n         commit #397\n    -    note for commit #397\n         commit #396\n    -    note for commit #396\n         commit #395\n\n  etc.\n\n\nRecall that this is a RHEL5.5 box that runs a little helper script on\na cronjob, which builds git and then runs the tests under valgrind.\nFor each failing test, it then bisects the failure (again with\nvalgrind).\n\nFeel free to ask if you need more information.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"153873","messageId":"7vvd4wvmv6.fsf@alter.siamese.dyndns.org","threadId":"25487","inReplyTo":"201010201148.51551.trast@student.ethz.ch","subject":"Re: Test failures in today's pu: 0025, 4046, 4203, 9300, 9301","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-10-20T16:40:29Z","receivedAt":"2010-10-20T16:40:29Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast <trast@student.ethz.ch> writes:\n\n> * t4203-mailmap: bisected to d8d2eb7d (mailmap: fix use of freed\n>   memory).  I saw some list traffic possibly related to this, is it\n>   fixed already?\n\nI found one issue that will trigger if you do not run this test with its\nstandard input corrected to a terminal and pushed out a fix last night.\nDid you have 3e3e1ef (t4203: do not let \"git shortlog\" DWIM based on tty,\n2010-10-19) when your automated test ran?\n\n> * t9300-fast-import: bisected to a544a23c (t9300 (fast-import):\n>   another test for the \"replace root\" feature).\n\nJonathan noticed breakage caused while I was applying his patch; should be\ncorrected as of last night with 971728c (t9300 (fast-import): another test\nfor the \"replace root\" feature, 2010-10-17).\n\n> * t9301-fast-import-notes: bisected to 5edde51 (fast-import:\n>   filemodify after M 040000 <tree> \"\" crashes).\n\nI saw this one too; it seems to happen with jn/fast-import-fix topic.\n"},{"id":"153876","messageId":"201010201856.54756.trast@student.ethz.ch","threadId":"25487","inReplyTo":"7vvd4wvmv6.fsf@alter.siamese.dyndns.org","subject":"Re: Test failures in today's pu: 0025, 4046, 4203, 9300, 9301","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-10-20T16:56:54Z","receivedAt":"2010-10-20T16:56:54Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Junio C Hamano wrote:\n> Thomas Rast <trast@student.ethz.ch> writes:\n> \n> > * t4203-mailmap: bisected to d8d2eb7d (mailmap: fix use of freed\n> >   memory).  I saw some list traffic possibly related to this, is it\n> >   fixed already?\n> \n> I found one issue that will trigger if you do not run this test with its\n> standard input corrected to a terminal and pushed out a fix last night.\n> Did you have 3e3e1ef (t4203: do not let \"git shortlog\" DWIM based on tty,\n> 2010-10-19) when your automated test ran?\n\nNo.  False alarm then?\n\n> > * t9300-fast-import: bisected to a544a23c (t9300 (fast-import):\n> >   another test for the \"replace root\" feature).\n> \n> Jonathan noticed breakage caused while I was applying his patch; should be\n> corrected as of last night with 971728c (t9300 (fast-import): another test\n> for the \"replace root\" feature, 2010-10-17).\n\nSame here.  I thought I saw a valgrind failure, but it was only caused\nby -O0 apparently.  In any case I cannot reproduce the test failur\nwith current pu (b19f0de).\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"155220","messageId":"201011042237.01801.trast@student.ethz.ch","threadId":"25487","inReplyTo":"201010201856.54756.trast@student.ethz.ch","subject":"Test failures in pu: 4046, 950[012]","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-11-04T21:37:01Z","receivedAt":"2010-11-04T21:37:01Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Failures as of yesterday (it alternates between next and pu, so today\nwas next which was clean):\n\n* 4046 has this valgrind failure:\n\n  ==24237== Source and destination overlap in mempcpy(0x7feffed50, 0x7feffed50, 2)\n  ==24237==    at 0x4C228DB: mempcpy (mc_replace_strmem.c:802)\n  ==24237==    by 0x511AD6: copy_dirname (diffcore-rename.c:573)\n  ==24237==    by 0x512071: check_one_bulk_move (diffcore-rename.c:744)\n  ==24237==    by 0x5120C0: diffcore_bulk_moves (diffcore-rename.c:756)\n  ==24237==    by 0x512988: diffcore_rename (diffcore-rename.c:961)\n  ==24237==    by 0x4A48EF: diffcore_std (diff.c:4252)\n  ==24237==    by 0x4974B5: run_diff_index (diff-lib.c:475)\n  ==24237==    by 0x4267CD: cmd_diff_index (diff-index.c:50)\n  ==24237==    by 0x404963: run_builtin (git.c:276)\n  ==24237==    by 0x404AEE: handle_internal_command (git.c:435)\n  ==24237==    by 0x404BD9: run_argv (git.c:479)\n  ==24237==    by 0x404D3A: main (git.c:554)\n  ==24237== \n  [snip suppression template]\n  not ok - 14 diff-index --detect-bulk-moves on a move including a subdir.\n\n\n* 950[012]: these are very strange.\n\nRunning them interactively appears to work ok, so maybe it is some\nenvironment bug.  They appear to be \"can't happen\" style failures\nthough, since they all look like (this one is from 9502)\n\n  Initialized empty Git repository in /local/home/trast/git/t/trash directory.t9502-gitweb-standalone-parse-output/.git/\n  expecting success: \n          test_commit first foo &&\n          git branch xx/test &&\n          FULL_ID=$(git rev-parse --verify HEAD) &&\n          SHORT_ID=$(git rev-parse --verify --short=7 HEAD)\n\n  fatal: This operation must be run in a work tree\n  not ok - 1 setup\n\nThey are the only ones failing with this problem, though.  They all\nbisect to\n\n  commit e60cb38c7c4e0bdb8f9542f9925ba5cafd4cd33b\n  Author: Nguyá»…n Thái Ngọc Duy <pclouds@gmail.com>\n  Date:   Fri Oct 29 13:48:50 2010 +0700\n\n      Remove all logic from get_git_work_tree()\n      \n      This helps break things some more. Eventually all repo setup logic\n      should be centralized in setup_* functions. This helps push all the\n      bugs back to setup_* functions.\n      \n      Signed-off-by: Nguyá»…n Thái Ngọc Duy <pclouds@gmail.com>\n      Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\n(Sorry, the UTF was garbled in cron-email transit...)\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"155221","messageId":"20101104214900.GD8911@home.lan","threadId":"25487","inReplyTo":"201011042237.01801.trast@student.ethz.ch","subject":"Re: Test failures in pu: 4046, 950[012]","fromName":"Yann Dirson","fromEmail":"ydirson@free.fr","sentAt":"2010-11-04T21:49:01Z","receivedAt":"2010-11-04T21:49:01Z","isPatch":false,"sender":{"key":"ydirson@free.fr","avatar":null},"body":"On Thu, Nov 04, 2010 at 10:37:01PM +0100, Thomas Rast wrote:\n> Failures as of yesterday (it alternates between next and pu, so today\n> was next which was clean):\n> \n> * 4046 has this valgrind failure:\n> \n>   ==24237== Source and destination overlap in mempcpy(0x7feffed50, 0x7feffed50, 2)\n>   ==24237==    at 0x4C228DB: mempcpy (mc_replace_strmem.c:802)\n>   ==24237==    by 0x511AD6: copy_dirname (diffcore-rename.c:573)\n\nThis is the issue raised by Jonathan.  I have a fix for it although I\ndid not publish it since I'm working on a refactoring.  Posting it now.\n\n-- \nYann\n"},{"id":"155243","messageId":"AANLkTinZJFb_sAH6AGD+ZMwj5boERAU3-NDkA3ve1+=F@mail.gmail.com","threadId":"25487","inReplyTo":"201011042237.01801.trast@student.ethz.ch","subject":"Re: Test failures in pu: 4046, 950[012]","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2010-11-05T02:20:04Z","receivedAt":"2010-11-05T02:20:04Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2010/11/5 Thomas Rast <trast@student.ethz.ch>:\n> * 950[012]: these are very strange.\n>\n> Running them interactively appears to work ok, so maybe it is some\n> environment bug.  They appear to be \"can't happen\" style failures\n\nCan you rerun it with GIT_TRACE=\"$TRASH_DIRECTORY/trace\" set on the\nfailed tests?\n\n> though, since they all look like (this one is from 9502)\n>\n>  Initialized empty Git repository in /local/home/trast/git/t/trash directory.t9502-gitweb-standalone-parse-output/.git/\n>  expecting success:\n>          test_commit first foo &&\n>          git branch xx/test &&\n>          FULL_ID=$(git rev-parse --verify HEAD) &&\n>          SHORT_ID=$(git rev-parse --verify --short=7 HEAD)\n>\n>  fatal: This operation must be run in a work tree\n>  not ok - 1 setup\n\nThis test is OK for me, although the next ones fail (pu db22585). How\ndo I debug gitweb.perl? t9502.2 shows\n\nFULL_ID  = 1005c80cc11c531d327b12195027cbbb4ff9e3cb\nSHORT_ID = 1005c80\nexpecting success:\n        gitweb_run \"p=.git;a=snapshot;h=$FULL_ID;sf=tar\" &&\n        check_snapshot \".git-$SHORT_ID\"\n\nbasename=.git-1005c80\ntar: This does not look like a tar archive\ntar: Exiting with failure status due to previous errors\nnot ok - 2 snapshot: full sha1\n\nNot very helpful.\n\nOn t9500.1, I get\n\n[Fri Nov  5 02:09:15 2010] gitweb.perl: Undefined subroutine\n&main::cache_fetch called at\n/home/pclouds/w/git/t/../gitweb/gitweb.perl line 1124.\n\nSetting PERLLIB makes it work, but shouldn't the test script have done\nthat already?\n-- \nDuy\n"},{"id":"155256","messageId":"m3zktof1u0.fsf@localhost.localdomain","threadId":"25487","inReplyTo":"AANLkTinZJFb_sAH6AGD+ZMwj5boERAU3-NDkA3ve1+=F@mail.gmail.com","subject":"Re: Test failures in pu: 4046, 950[012]","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-11-05T11:28:01Z","receivedAt":"2010-11-05T11:28:01Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:\n\n> On t9500.1, I get\n> \n> [Fri Nov  5 02:09:15 2010] gitweb.perl: Undefined subroutine\n> &main::cache_fetch called at\n> /home/pclouds/w/git/t/../gitweb/gitweb.perl line 1124.\n> \n> Setting PERLLIB makes it work, but shouldn't the test script have done\n> that already?\n\nSee http://article.gmane.org/gmane.comp.version-control.git/160395\n\nFixed in http://thread.gmane.org/gmane.comp.version-control.git/160147/focus=160476\n(minimal fixup), not yet in 'pu'.\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"}]}