threads / patch / 25092

patchDocumentation: Refer to git-commit-tree in git-filter-branch help

Subject: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help

## tl;dr

4 messages between Sep 13, 2010 and Sep 27, 2010. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Wesley J. Landaker· Sep 13, 2010, 14:59 UTC · lore

Currently, the help for git filter-branch refers users of --env-filter to git-commit for information about environment variables affecting commits. However, this information is not contained in the git-commit help, but is very explicitly detailed in git-commit-tree.

Signed-off-by: Wesley J. Landaker <wjl@icecavern.net>
---
 Documentation/git-filter-branch.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to Documentation/git-filter-branch.txt +1 −1
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index 020028c..c32e489 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -81,7 +81,7 @@ OPTIONS
 	This filter may be used if you only need to modify the environment
 	in which the commit will be performed.  Specifically, you might
 	want to rewrite the author/committer name/email/time environment
-	variables (see linkgit:git-commit[1] for details).  Do not forget
+	variables (see linkgit:git-commit-tree[1] for details).  Do not forget
 	to re-export the variables.
 
 --tree-filter <command>::

-- 
1.7.1
Wesley J. Landaker· Sep 24, 2010, 16:12 UTC · re: Wesley J. Landaker · lore

Re: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help

On Monday, September 13, 2010 08:59:54 Wesley J. Landaker wrote:
> Currently, the help for git filter-branch refers users of --env-filter
> to git-commit for information about environment variables affecting
> commits. However, this information is not contained in the git-commit
> help, but is very explicitly detailed in git-commit-tree.
Was there something disagreeable about this patch, or did it just get lost?

I'd like to help make it easier for others who might find themselves on a hunt for the right environment variables for --env-filter like I was.

Elijah Newren· Sep 26, 2010, 02:04 UTC · re: Wesley J. Landaker · lore

Re: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help

On Fri, Sep 24, 2010 at 10:12 AM, Wesley J. Landaker <wjl@icecavern.net> wrote:
Show 10 quoted lines
> On Monday, September 13, 2010 08:59:54 Wesley J. Landaker wrote:
>> Currently, the help for git filter-branch refers users of --env-filter
>> to git-commit for information about environment variables affecting
>> commits. However, this information is not contained in the git-commit
>> help, but is very explicitly detailed in git-commit-tree.
>
> Was there something disagreeable about this patch, or did it just get lost?
>
> I'd like to help make it easier for others who might find themselves on a
> hunt for the right environment variables for --env-filter like I was.

I'm guessing it just got lost; the patch looks good to me, and I think it makes for a nice improvement for folks trying to find the information they need.

← back to recent threads