{"thread":{"id":"25092","subject":"[PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help","startedAt":"2010-09-13T14:59:54Z","lastAt":"2010-09-27T22:19:31Z","messageCount":4,"participants":["Wesley J. Landaker","Elijah Newren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"150597","messageId":"1284389994-16892-1-git-send-email-wjl@icecavern.net","threadId":"25092","inReplyTo":null,"subject":"[PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2010-09-13T14:59:54Z","receivedAt":"2010-09-13T14:59:54Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"Currently, the help for git filter-branch refers users of --env-filter\nto git-commit for information about environment variables affecting\ncommits. However, this information is not contained in the git-commit\nhelp, but is very explicitly detailed in git-commit-tree.\n\nSigned-off-by: Wesley J. Landaker <wjl@icecavern.net>\n---\n Documentation/git-filter-branch.txt |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt\nindex 020028c..c32e489 100644\n--- a/Documentation/git-filter-branch.txt\n+++ b/Documentation/git-filter-branch.txt\n@@ -81,7 +81,7 @@ OPTIONS\n \tThis filter may be used if you only need to modify the environment\n \tin which the commit will be performed.  Specifically, you might\n \twant to rewrite the author/committer name/email/time environment\n-\tvariables (see linkgit:git-commit[1] for details).  Do not forget\n+\tvariables (see linkgit:git-commit-tree[1] for details).  Do not forget\n \tto re-export the variables.\n \n --tree-filter <command>::\n-- \n1.7.1\n"},{"id":"151506","messageId":"201009241012.44861.wjl@icecavern.net","threadId":"25092","inReplyTo":"1284389994-16892-1-git-send-email-wjl@icecavern.net","subject":"Re: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2010-09-24T16:12:44Z","receivedAt":"2010-09-24T16:12:44Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"On Monday, September 13, 2010 08:59:54 Wesley J. Landaker wrote:\n> Currently, the help for git filter-branch refers users of --env-filter\n> to git-commit for information about environment variables affecting\n> commits. However, this information is not contained in the git-commit\n> help, but is very explicitly detailed in git-commit-tree.\n\nWas there something disagreeable about this patch, or did it just get lost? \n\nI'd like to help make it easier for others who might find themselves on a \nhunt for the right environment variables for --env-filter like I was.\n"},{"id":"151698","messageId":"AANLkTin+CiNBqn-Zbz4h6M9P7fhYRd3mvwYJ9tzXL-2r@mail.gmail.com","threadId":"25092","inReplyTo":"201009241012.44861.wjl@icecavern.net","subject":"Re: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2010-09-26T02:04:59Z","receivedAt":"2010-09-26T02:04:59Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Fri, Sep 24, 2010 at 10:12 AM, Wesley J. Landaker <wjl@icecavern.net> wrote:\n> On Monday, September 13, 2010 08:59:54 Wesley J. Landaker wrote:\n>> Currently, the help for git filter-branch refers users of --env-filter\n>> to git-commit for information about environment variables affecting\n>> commits. However, this information is not contained in the git-commit\n>> help, but is very explicitly detailed in git-commit-tree.\n>\n> Was there something disagreeable about this patch, or did it just get lost?\n>\n> I'd like to help make it easier for others who might find themselves on a\n> hunt for the right environment variables for --env-filter like I was.\n\nI'm guessing it just got lost; the patch looks good to me, and I think\nit makes for a nice improvement for folks trying to find the\ninformation they need.\n"},{"id":"151857","messageId":"7vsk0ux218.fsf@alter.siamese.dyndns.org","threadId":"25092","inReplyTo":"1284389994-16892-1-git-send-email-wjl@icecavern.net","subject":"Re: [PATCH] Documentation: Refer to git-commit-tree in git-filter-branch help","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-27T22:19:31Z","receivedAt":"2010-09-27T22:19:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}