threads / bug / 25024

[BUG] git-send-email format-patch awareness & retry

Subject: [BUG] git-send-email format-patch awareness & retry

## tl;dr

4 messages between Sep 7, 2010 and Sep 9, 2010.

replies: 3people: 3as markdown or json

Ævar Arnfjörð Bjarmason· Sep 7, 2010, 16:59 UTC · lore

(cc primary authors & Junio)

This is more of a TODO note to myself than a bug, but if someone else gets around to fixing these that'd be great too.

git-send-email should:

 * Complain loudly on "*** SUBJECT HERE ***" and "*** BLURB HERE ***"

   This should have an additional "are you sure" dialog:

    Subject: [PATCH 00/20] *** SUBJECT HERE ***
    Date: Tue,  7 Sep 2010 16:43:03 +0000
    Message-Id: <1283877803-17757-1-git-send-email-avarab@gmail.com>
    X-Mailer: git-send-email 1.7.2.3.313.gcd15
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit

    Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
    Password:

 * Retry before bailing out:

   It's annoying to lose state because of temporary SMTP errors. This
   should offer to sleep for a few seconds and retry:

    Content-Transfer-Encoding: 8bit

    Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
     Go ahead k83sm4304468weq.14
    4.3.0 Mail server temporarily rejected message. k83sm4304468weq.14

It would also be a lot easier to catch errors in the git-send-email output if it supported colors, e.g. colored the subject line differently from others.

Thomas Rast· Sep 8, 2010, 09:14 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [BUG] git-send-email format-patch awareness & retry

Ævar Arnfjörð Bjarmason wrote:

Show 21 quoted lines

> (cc primary authors & Junio)
> 
> This is more of a TODO note to myself than a bug, but if someone else
> gets around to fixing these that'd be great too.
> 
> git-send-email should:
> 
>  * Complain loudly on "*** SUBJECT HERE ***" and "*** BLURB HERE ***"
> 
>    This should have an additional "are you sure" dialog:
> 
>     Subject: [PATCH 00/20] *** SUBJECT HERE ***
>     Date: Tue,  7 Sep 2010 16:43:03 +0000
>     Message-Id: <1283877803-17757-1-git-send-email-avarab@gmail.com>
>     X-Mailer: git-send-email 1.7.2.3.313.gcd15
>     MIME-Version: 1.0
>     Content-Type: text/plain; charset=UTF-8
>     Content-Transfer-Encoding: 8bit
> 
>     Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
>     Password:

You could resurrect

  http://mid.gmane.org/7fedc4b76fed03e4db6a2bb7453609c9cd02928a.1244496564.git.trast@student.ethz.ch

though on re-reading I'm not so sure anymore that *any* complaints remained.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

Junio C Hamano· Sep 8, 2010, 16:04 UTC · re: Thomas Rast · lore

Re: [BUG] git-send-email format-patch awareness & retry

Thomas Rast <trast@student.ethz.ch> writes:

Show 6 quoted lines

> You could resurrect
>
>   http://mid.gmane.org/7fedc4b76fed03e4db6a2bb7453609c9cd02928a.1244496564.git.trast@student.ethz.ch
>
> though on re-reading I'm not so sure anymore that *any* complaints
> remained.

I think I got distracted in the follow-up discussion and forgot about that patch.

And the patch looks sane; let's queue it, so that I won't forget about it again.

Thanks.

Thomas Rast· Sep 9, 2010, 08:08 UTC · re: Junio C Hamano · lore

Re: [BUG] git-send-email format-patch awareness & retry

Junio C Hamano wrote:

Show 7 quoted lines

> I think I got distracted in the follow-up discussion and forgot about that
> patch.
> 
> And the patch looks sane; let's queue it, so that I won't forget about it
> again.
> 
> Thanks.

Thanks. No need to apologize; I forgot too, and only remembered when Ævar mentioned the topic again.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch