# [BUG] git-send-email format-patch awareness & retry 4 messages from 2010-09-07 to 2010-09-09. Participants: Ævar Arnfjörð Bjarmason, Thomas Rast, Junio C Hamano. Thread: https://gitlist.dev/t/25024 ## Ævar Arnfjörð Bjarmason, 2010-09-07 16:59 Subject: [BUG] git-send-email format-patch awareness & retry Message-ID: URL: https://gitlist.dev/e/AANLkTimtOguHdcs%2BQYj7ePNeyMNsWYLDu%2ByfyOPrDWUG%40mail.gmail.com ``` (cc primary authors & Junio) This is more of a TODO note to myself than a bug, but if someone else gets around to fixing these that'd be great too. git-send-email should: * Complain loudly on "*** SUBJECT HERE ***" and "*** BLURB HERE ***" This should have an additional "are you sure" dialog: Subject: [PATCH 00/20] *** SUBJECT HERE *** Date: Tue, 7 Sep 2010 16:43:03 +0000 Message-Id: <1283877803-17757-1-git-send-email-avarab@gmail.com> X-Mailer: git-send-email 1.7.2.3.313.gcd15 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Send this email? ([y]es|[n]o|[q]uit|[a]ll): y Password: * Retry before bailing out: It's annoying to lose state because of temporary SMTP errors. This should offer to sleep for a few seconds and retry: Content-Transfer-Encoding: 8bit Send this email? ([y]es|[n]o|[q]uit|[a]ll): y Go ahead k83sm4304468weq.14 4.3.0 Mail server temporarily rejected message. k83sm4304468weq.14 It would also be a lot easier to catch errors in the git-send-email output if it supported colors, e.g. colored the subject line differently from others. ``` ## Thomas Rast, 2010-09-08 09:14 Subject: Re: [BUG] git-send-email format-patch awareness & retry Message-ID: <201009081114.18263.trast@student.ethz.ch> URL: https://gitlist.dev/e/201009081114.18263.trast%40student.ethz.ch In-Reply-To: ``` Ævar Arnfjörð Bjarmason wrote: > (cc primary authors & Junio) > > This is more of a TODO note to myself than a bug, but if someone else > gets around to fixing these that'd be great too. > > git-send-email should: > > * Complain loudly on "*** SUBJECT HERE ***" and "*** BLURB HERE ***" > > This should have an additional "are you sure" dialog: > > Subject: [PATCH 00/20] *** SUBJECT HERE *** > Date: Tue, 7 Sep 2010 16:43:03 +0000 > Message-Id: <1283877803-17757-1-git-send-email-avarab@gmail.com> > X-Mailer: git-send-email 1.7.2.3.313.gcd15 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > Send this email? ([y]es|[n]o|[q]uit|[a]ll): y > Password: You could resurrect http://mid.gmane.org/7fedc4b76fed03e4db6a2bb7453609c9cd02928a.1244496564.git.trast@student.ethz.ch though on re-reading I'm not so sure anymore that *any* complaints remained. -- Thomas Rast trast@{inf,student}.ethz.ch ``` ## Junio C Hamano, 2010-09-08 16:04 Subject: Re: [BUG] git-send-email format-patch awareness & retry Message-ID: <7vk4mwnrwt.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk4mwnrwt.fsf%40alter.siamese.dyndns.org In-Reply-To: <201009081114.18263.trast@student.ethz.ch> ``` Thomas Rast writes: > You could resurrect > > http://mid.gmane.org/7fedc4b76fed03e4db6a2bb7453609c9cd02928a.1244496564.git.trast@student.ethz.ch > > though on re-reading I'm not so sure anymore that *any* complaints > remained. I think I got distracted in the follow-up discussion and forgot about that patch. And the patch looks sane; let's queue it, so that I won't forget about it again. Thanks. ``` ## Thomas Rast, 2010-09-09 08:08 Subject: Re: [BUG] git-send-email format-patch awareness & retry Message-ID: <201009091008.59531.trast@student.ethz.ch> URL: https://gitlist.dev/e/201009091008.59531.trast%40student.ethz.ch In-Reply-To: <7vk4mwnrwt.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > I think I got distracted in the follow-up discussion and forgot about that > patch. > > And the patch looks sane; let's queue it, so that I won't forget about it > again. > > Thanks. Thanks. No need to apologize; I forgot too, and only remembered when Ævar mentioned the topic again. -- Thomas Rast trast@{inf,student}.ethz.ch ```